Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: utils.Trim should trim all string content #1775

Merged
merged 3 commits into from Feb 14, 2022

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Feb 13, 2022

Please provide enough information so that others can review your pull request:

This PR fix a edge case of utils.Trim(" ", ' ') returning " " instead of "".

close #1774

Explain the details for making this change. What existing problem does the pull request solve?

fix edge case utils.Trim(" ", ' ') and Trim(" ", ' ')

Commit formatting

not a fan of emojis, choose whatever you like when merging.

@welcome
Copy link

welcome bot commented Feb 13, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@trim21
Copy link
Contributor Author

trim21 commented Feb 13, 2022

Just push a better fix.

@trim21
Copy link
Contributor Author

trim21 commented Feb 14, 2022

flaky test?

@ReneWerner87 ReneWerner87 merged commit 391ae59 into gofiber:master Feb 14, 2022
14 checks passed
@welcome
Copy link

welcome bot commented Feb 14, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@trim21 trim21 deleted the patch-1 branch Feb 14, 2022
@ReneWerner87
Copy link
Member

ReneWerner87 commented Feb 14, 2022

flaky test?

perhaps, we will analyze soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants