Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "馃悰 Sub fiber's error handlers not working #1839" and "馃悰 Mount sub fiber app on '/' #1842" #1848

Merged
merged 1 commit into from Apr 5, 2022

Conversation

ReneWerner87
Copy link
Member

@ReneWerner87 ReneWerner87 commented Apr 4, 2022

Fix for "馃悰 Sub fiber's error handlers not working #1839"
Fix for "馃悰 Mount sub fiber app on "/" #1842"

Reason for the bugs:
problem was solved by optimizing the mounting
there the functionality for the root path was broken, because there a trimRight with "/" was used
https://github.com/gofiber/fiber/pull/1749/files

@ReneWerner87 ReneWerner87 linked an issue Apr 4, 2022 that may be closed by this pull request
@ReneWerner87 ReneWerner87 merged commit a8f9d4a into master Apr 5, 2022
31 checks passed
@ReneWerner87 ReneWerner87 linked an issue Apr 5, 2022 that may be closed by this pull request
@ReneWerner87 ReneWerner87 changed the title Fix for "馃悰 Sub fiber's error handlers not working #1839" Fix for "馃悰 Sub fiber's error handlers not working #1839" and "馃悰 Mount sub fiber app on '/' #1842" Apr 5, 2022
@efectn efectn deleted the subFiberErrorHandler branch Jun 25, 2022
trim21 pushed a commit to trim21/fiber that referenced this pull request Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant