Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搳 add page title to monitor mw #1893

Merged
merged 1 commit into from May 5, 2022
Merged

Conversation

jfcg
Copy link
Contributor

@jfcg jfcg commented May 4, 2022

Hi,

This MR adds ability to change monitor middleware's html page title.

Cheers 馃帀

efectn
efectn approved these changes May 4, 2022
@jfcg
Copy link
Contributor Author

jfcg commented May 4, 2022

Should we delete index.html ?

@ReneWerner87
Copy link
Member

ReneWerner87 commented May 5, 2022

Should we delete index.html ?

yes please and add a part in our doc repository for the new setting

@jfcg
Copy link
Contributor Author

jfcg commented May 5, 2022

also updated charts.js version to latest 2.9 which is currently 2.9.4. it works fine in my test.

@ReneWerner87 ReneWerner87 merged commit 29be669 into gofiber:master May 5, 2022
16 checks passed
@jfcg jfcg deleted the metrics-title branch May 5, 2022
@ReneWerner87
Copy link
Member

ReneWerner87 commented May 7, 2022

yes please and add a part in our doc repository for the new setting

@jfcg is this done?

@jfcg
Copy link
Contributor Author

jfcg commented May 7, 2022

docs repo PR 馃憤馃徏

trim21 pushed a commit to trim21/fiber that referenced this issue Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants