Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor favicon middleware, avoid magic numbers. #1919

Merged
merged 2 commits into from May 28, 2022

Conversation

vikpe
Copy link
Contributor

@vikpe vikpe commented May 27, 2022

Increase readability / follow best practices.

@welcome
Copy link

welcome bot commented May 27, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Hi, what about the benchmark

Does this adjustment cost allocations?

@vikpe
Copy link
Contributor Author

vikpe commented May 28, 2022

Update: I introduced a constant for the standard path and ran the benchmark.

master

cpu: Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz
Benchmark_Middleware_Favicon
Benchmark_Middleware_Favicon-4          13465311                86.32 ns/op            3 B/op          1 allocs/op
Benchmark_Middleware_Favicon-4          13408497                87.49 ns/op            3 B/op          1 allocs/op
Benchmark_Middleware_Favicon-4          13480440                87.96 ns/op            3 B/op          1 allocs/op
Benchmark_Middleware_Favicon-4          12733093                87.11 ns/op            3 B/op          1 allocs/op

pr

cpu: Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz
Benchmark_Middleware_Favicon
Benchmark_Middleware_Favicon-4          13345022                86.64 ns/op            3 B/op          1 allocs/op
Benchmark_Middleware_Favicon-4          13459353                86.65 ns/op            3 B/op          1 allocs/op
Benchmark_Middleware_Favicon-4          13541000                86.20 ns/op            3 B/op          1 allocs/op
Benchmark_Middleware_Favicon-4          13520474                86.09 ns/op            3 B/op          1 allocs/op

However I guess one need to run benchmarks on a dedicated setup (not my dev computer) for persistent results.

@ReneWerner87 ReneWerner87 merged commit 68e922d into gofiber:master May 28, 2022
16 checks passed
@welcome
Copy link

welcome bot commented May 28, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

trim21 pushed a commit to trim21/fiber that referenced this issue Aug 15, 2022
* Refactor favicon middleware, avoid magic numbers.

* Introduce constant for path to favicon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants