Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some parameters to config for supporting #1936 #1956

Merged
merged 4 commits into from Jul 5, 2022

Conversation

taheri24
Copy link
Contributor

@taheri24 taheri24 commented Jun 29, 2022

Is your feature request related to a problem?
#1936

better implantation than
3f3aa77

@welcome
Copy link

welcome bot commented Jun 29, 2022

Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

@efectn
Copy link
Member

efectn commented Jun 29, 2022

nice implementation but //go:embed just works on 1.16 and later.

@taheri24
Copy link
Contributor Author

taheri24 commented Jun 29, 2022

please merge my contribute , I so excited

Copy link
Member

@efectn efectn left a comment

  • Add unit test cases (similar: middleware/monitor/monitor_test.go)
  • Add comment lines for new config fields and update README.md.
  • Create a PR in docs repo.
  • Remove tpl file since we don't need it

@efectn
Copy link
Member

efectn commented Jun 29, 2022

Check my review @taheri24

@taheri24
Copy link
Contributor Author

taheri24 commented Jun 29, 2022

please check it .

efectn
efectn approved these changes Jun 29, 2022
Copy link
Member

@efectn efectn left a comment

lgtm

@ReneWerner87 ReneWerner87 merged commit 744e4da into gofiber:master Jul 5, 2022
21 checks passed
@welcome
Copy link

welcome bot commented Jul 5, 2022

Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord

trim21 pushed a commit to trim21/fiber that referenced this pull request Aug 15, 2022
* add some parameters to config for supporting gofiber#1936

* remove go:embed

* apply code review  - 1956#issuecomment-1169811117

* lint

Co-authored-by: Muhammed Efe Çetin <efectn@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants