Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binds the param string to a struct use params tag #1968

Merged
merged 3 commits into from Jul 6, 2022

Conversation

olongfen
Copy link
Contributor

@olongfen olongfen commented Jul 6, 2022

binds the param string to a struct use params tag

	app.Get("/test1/userId/role/:roleId", func(ctx *Ctx) error {
		type Demo struct {
			UserID uint `params:"userId"`
			RoleID uint `params:"roleId"`
		}
		var (
			d = new(Demo)
		)
		ctx.ParamsParser(d)
		return nil

@olongfen olongfen closed this Jul 6, 2022
@olongfen olongfen reopened this Jul 6, 2022
@olongfen olongfen closed this Jul 6, 2022
@olongfen olongfen reopened this Jul 6, 2022
@olongfen
Copy link
Contributor Author

olongfen commented Jul 6, 2022

@ReneWerner87 This check sometime 1.17.x failed in macos, sometime 1.16.x failed in macos

@olongfen olongfen closed this Jul 6, 2022
@olongfen olongfen reopened this Jul 6, 2022
@ReneWerner87 ReneWerner87 merged commit bad7001 into gofiber:master Jul 6, 2022
58 of 81 checks passed
@ReneWerner87
Copy link
Member

ReneWerner87 commented Jul 6, 2022

@ReneWerner87 This check sometime 1.17.x failed in macos, sometime 1.16.x failed in macos

yes we know, we have to make this more stable somehow
the timeout tests are not really stable

trim21 pushed a commit to trim21/fiber that referenced this issue Aug 15, 2022
* add: params parse

* fix: binds the param string to a struct use params tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants