New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-bindata #7

Closed
bcho opened this Issue Aug 4, 2018 · 10 comments

Comments

Projects
None yet
7 participants
@bcho

bcho commented Aug 4, 2018

  • Where is the project currently hosted?

Multiple forks, most are based with https://github.com/go-bindata/go-bindata

  • Is the project written only in Go, or does it contain other languages (beyond scripts)?

In pure go.

  • Has the project had any recent activity?

Most forks made small changes.

  • Does the project have a maintainer, or a maintainer looking for someone to take
    over the project?

No active maintainer for now, since the original maintainer deleted all his packages (jteeuwen/go-bindata#5).

  • Do you have any example projects that make use of this package?

go-bindata is mostly used as a binary.

  • Are there any outstanding critical bugs that result in the library being
    totally unusable or insecure?

Not yet. But the maintainer / ownership of the repo is unclear, and some of the forks added minor changes without a clear intention.

  • Is there anything else you'd like to mention about the project?

cc @franklinyu

@fortytw2

This comment has been minimized.

Show comment
Hide comment
@fortytw2

fortytw2 Aug 6, 2018

Ooh. I've been using and recommending use of @lestrrat's fork found at https://github.com/lestrrat-go/bindata for the past 18 months or so.

Would be happy to lend a hand here.

fortytw2 commented Aug 6, 2018

Ooh. I've been using and recommending use of @lestrrat's fork found at https://github.com/lestrrat-go/bindata for the past 18 months or so.

Would be happy to lend a hand here.

@franklinyu

This comment has been minimized.

Show comment
Hide comment
@franklinyu

franklinyu Aug 6, 2018

Just another datapoint: Homebrew selected kevinburke/go-bindata. The go-bindata/go-bindata mentioned above gets most stars though.

franklinyu commented Aug 6, 2018

Just another datapoint: Homebrew selected kevinburke/go-bindata. The go-bindata/go-bindata mentioned above gets most stars though.

@pedromorgan

This comment has been minimized.

Show comment
Hide comment
@pedromorgan

pedromorgan Aug 6, 2018

Well into the "maintained idea" of this one.. am on the second fork.... want the stable fork...

pedromorgan commented Aug 6, 2018

Well into the "maintained idea" of this one.. am on the second fork.... want the stable fork...

@theckman

This comment has been minimized.

Show comment
Hide comment
@theckman

theckman Aug 11, 2018

Member

I think this is a good project to take over. The scope is pretty focused, and it's relied on heavily by the community. It's also one of Go's "leftpad" packages, and so it's in a spot where it'd be nice to have a good story around maintaining the project.

What do we feel would be the right project / commit to fork from? Are there any good idea of outstanding issues or feature requests we should look to tackle?

Would someone be interested in doing this type of research, and present where they think we should do a hard fork from as well as what things we should look to address first?

Member

theckman commented Aug 11, 2018

I think this is a good project to take over. The scope is pretty focused, and it's relied on heavily by the community. It's also one of Go's "leftpad" packages, and so it's in a spot where it'd be nice to have a good story around maintaining the project.

What do we feel would be the right project / commit to fork from? Are there any good idea of outstanding issues or feature requests we should look to tackle?

Would someone be interested in doing this type of research, and present where they think we should do a hard fork from as well as what things we should look to address first?

@josharian

This comment has been minimized.

Show comment
Hide comment
@josharian

josharian commented Aug 13, 2018

@kevinburke

This comment has been minimized.

Show comment
Hide comment
@kevinburke

kevinburke Aug 13, 2018

kevinburke commented Aug 13, 2018

@kevinburke

This comment has been minimized.

Show comment
Hide comment
@kevinburke

kevinburke Aug 14, 2018

Some of the issues I've fixed include:

  • writing the bindata.go file is now atomic

  • gofmt used to generate a Git diff when applied to the generated bindata.go file, now it doesn't

  • more error checking on file write

Some features added:

  • get the SHA256 digest of a file

  • file sizes appear in the TOC

  • benchmarks

  • performance improvements

  • AssetString and MustAssetString helper functions

kevinburke commented Aug 14, 2018

Some of the issues I've fixed include:

  • writing the bindata.go file is now atomic

  • gofmt used to generate a Git diff when applied to the generated bindata.go file, now it doesn't

  • more error checking on file write

Some features added:

  • get the SHA256 digest of a file

  • file sizes appear in the TOC

  • benchmarks

  • performance improvements

  • AssetString and MustAssetString helper functions

@theckman

This comment has been minimized.

Show comment
Hide comment
@theckman

theckman Aug 15, 2018

Member

and I’m committed to maintaining it!

So based on @kevinburke's comment, does it make sense to close this issue citing his fork as being the answer?

If so, @kevinburke if you'd ever like to stop having to watch over it, or need help, we'd definitely be interested in picking up the project.

Member

theckman commented Aug 15, 2018

and I’m committed to maintaining it!

So based on @kevinburke's comment, does it make sense to close this issue citing his fork as being the answer?

If so, @kevinburke if you'd ever like to stop having to watch over it, or need help, we'd definitely be interested in picking up the project.

@kevinburke

This comment has been minimized.

Show comment
Hide comment
@kevinburke

kevinburke Aug 15, 2018

Sounds good!

kevinburke commented Aug 15, 2018

Sounds good!

@theckman

This comment has been minimized.

Show comment
Hide comment
@theckman
Member

theckman commented Aug 16, 2018

Closing this in favor of: https://github.com/kevinburke/go-bindata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment