Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upgo-bindata #7
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fortytw2
Aug 6, 2018
Ooh. I've been using and recommending use of @lestrrat's fork found at https://github.com/lestrrat-go/bindata for the past 18 months or so.
Would be happy to lend a hand here.
fortytw2
commented
Aug 6, 2018
|
Ooh. I've been using and recommending use of @lestrrat's fork found at https://github.com/lestrrat-go/bindata for the past 18 months or so. Would be happy to lend a hand here. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
franklinyu
Aug 6, 2018
Just another datapoint: Homebrew selected kevinburke/go-bindata. The go-bindata/go-bindata mentioned above gets most stars though.
franklinyu
commented
Aug 6, 2018
|
Just another datapoint: Homebrew selected kevinburke/go-bindata. The go-bindata/go-bindata mentioned above gets most stars though. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pedromorgan
Aug 6, 2018
Well into the "maintained idea" of this one.. am on the second fork.... want the stable fork...
pedromorgan
commented
Aug 6, 2018
|
Well into the "maintained idea" of this one.. am on the second fork.... want the stable fork... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
theckman
Aug 11, 2018
Member
I think this is a good project to take over. The scope is pretty focused, and it's relied on heavily by the community. It's also one of Go's "leftpad" packages, and so it's in a spot where it'd be nice to have a good story around maintaining the project.
What do we feel would be the right project / commit to fork from? Are there any good idea of outstanding issues or feature requests we should look to tackle?
Would someone be interested in doing this type of research, and present where they think we should do a hard fork from as well as what things we should look to address first?
|
I think this is a good project to take over. The scope is pretty focused, and it's relied on heavily by the community. It's also one of Go's "leftpad" packages, and so it's in a spot where it'd be nice to have a good story around maintaining the project. What do we feel would be the right project / commit to fork from? Are there any good idea of outstanding issues or feature requests we should look to tackle? Would someone be interested in doing this type of research, and present where they think we should do a hard fork from as well as what things we should look to address first? |
theckman
added
good candidate
needs investigation
labels
Aug 11, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
josharian
commented
Aug 13, 2018
|
cc @kevinburke |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kevinburke
Aug 13, 2018
kevinburke
commented
Aug 13, 2018
|
Hey, yeah, if you run “brew install go-bindata” you get my fork now and I’m
committed to maintaining it!
On Mon, Aug 13, 2018 at 16:51 Josh Bleecher Snyder ***@***.***> wrote:
cc @kevinburke <https://github.com/kevinburke>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOSI_I66Iqh9LRnP7XyOEOfVNMZbarKks5uQZJfgaJpZM4VvFb8>
.
--
…--
Kevin Burke
925.271.7005 | kev.inburke.com
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kevinburke
Aug 14, 2018
Some of the issues I've fixed include:
-
writing the bindata.go file is now atomic
-
gofmt used to generate a Git diff when applied to the generated bindata.go file, now it doesn't
-
more error checking on file write
Some features added:
-
get the SHA256 digest of a file
-
file sizes appear in the TOC
-
benchmarks
-
performance improvements
-
AssetStringandMustAssetStringhelper functions
kevinburke
commented
Aug 14, 2018
|
Some of the issues I've fixed include:
Some features added:
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
theckman
Aug 15, 2018
Member
and I’m committed to maintaining it!
So based on @kevinburke's comment, does it make sense to close this issue citing his fork as being the answer?
If so, @kevinburke if you'd ever like to stop having to watch over it, or need help, we'd definitely be interested in picking up the project.
So based on @kevinburke's comment, does it make sense to close this issue citing his fork as being the answer? If so, @kevinburke if you'd ever like to stop having to watch over it, or need help, we'd definitely be interested in picking up the project. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kevinburke
commented
Aug 15, 2018
|
Sounds good! |
theckman
added
fork already available
and removed
good candidate
needs investigation
labels
Aug 16, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Closing this in favor of: https://github.com/kevinburke/go-bindata |
bcho commentedAug 4, 2018
Multiple forks, most are based with https://github.com/go-bindata/go-bindata
In pure go.
Most forks made small changes.
over the project?
No active maintainer for now, since the original maintainer deleted all his packages (jteeuwen/go-bindata#5).
go-bindata is mostly used as a binary.
totally unusable or insecure?
Not yet. But the maintainer / ownership of the repo is unclear, and some of the forks added minor changes without a clear intention.
cc @franklinyu