Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upOutstanding open issues / PRs in satori/go.uuid #32
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I pinged PR-44 to ask if they'd be willing to re-open the PR here. |
theckman
referenced this issue
Jul 23, 2018
Merged
Add JSON (Un)marshaling methods on NullUUID type #38
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
theckman
Jul 23, 2018
Member
I think we might be nearing the ability to close this ticket. We should give a final
Here's a quick classification of their PRs:
Desired / In-Progress
Fixed by this package:
Obsoleted by this package
- satori/go.uuid#68 (in that we've released a major version)
Unsure if we want to support this:
- satori/go.uuid#63 (Request: satori/go.uuid#64)
Issues
Feature requests:
Deprecation requests:
Fixed by this package:
- satori/go.uuid#82
- satori/go.uuid#80
- satori/go.uuid#77
- satori/go.uuid#76
- satori/go.uuid#73
- satori/go.uuid#71
- satori/go.uuid#70
- satori/go.uuid#69
- satori/go.uuid#66
Random questions (should probably be closed):
|
I think we might be nearing the ability to close this ticket. We should give a final Here's a quick classification of their PRs: Desired / In-Progress Fixed by this package: Obsoleted by this package
Unsure if we want to support this:
Issues Feature requests: Deprecation requests: Fixed by this package:
Random questions (should probably be closed): |
theckman
self-assigned this
Jul 23, 2018
theckman
added
the
help wanted
label
Jul 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
theckman
Jul 23, 2018
Member
Do we want to support the ability to generate random MAC addresses for V1 IDs as an option? There an issue (64) and PR open (63) on the other repo to support this functionality, and figured I'd poll here before asking.
|
Do we want to support the ability to generate random MAC addresses for V1 IDs as an option? There an issue (64) and PR open (63) on the other repo to support this functionality, and figured I'd poll here before asking. |
theckman
added
input wanted
and removed
help wanted
labels
Jul 23, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jadr2ddude
Jul 23, 2018
Member
I think it makes more sense to allow the user to specify a MAC than to generate a random MAC.
|
I think it makes more sense to allow the user to specify a MAC than to generate a random MAC. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zerkms
Jul 26, 2018
Member
There is a hwAddrFunc field available: if we expose it via another constructor - a user may provide a function that returns a random mac every time.
|
There is a |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
theckman
Jul 28, 2018
Member
We're likely going to need to expose the generator implementation, so that it can be done that way. I think this could be done in a minor release if we wanted, as we'd be adding-on.
|
We're likely going to need to expose the generator implementation, so that it can be done that way. I think this could be done in a minor release if we wanted, as we'd be adding-on. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
theckman
Jul 29, 2018
Member
I'm going to close this issue out now, since I think we're engaged on the things we should be engaged on. We can follow those up in the individual PRs/issues.
Thank you for raising this, and for the input that was given by everyone.
|
I'm going to close this issue out now, since I think we're engaged on the things we should be engaged on. We can follow those up in the individual PRs/issues. Thank you for raising this, and for the input that was given by everyone. |
acln0 commentedJul 19, 2018
We should take a look at the open issues and pending PRs in https://github.com/satori/go.uuid and see if which ones would be worth tackling / adopting.
satori/go.uuid#44 was brought up, which I think is a good start.
Please comment with other issues or PRs if you think they'd be worth doing.