Tiny code simplification in codec #54
Conversation
2 similar comments
| @@ -125,7 +125,7 @@ func (u *UUID) decodeCanonical(t []byte) error { | |||
| return fmt.Errorf("uuid: incorrect UUID format %s", t) | |||
| } | |||
|
|
|||
| src := t[:] | |||
There was a problem hiding this comment.
Could this be an optimization? I recall a talk from today talking about "this being on the stack" now IIRC.
Can we benchmark before and after?
There was a problem hiding this comment.
Both are values on stack I presume
There was a problem hiding this comment.
The t value is already a slice i think. The [:] should be a no-op.
There was a problem hiding this comment.
It looks like a no-op indeed https://go.godbolt.org/z/OuMHTy
There was a problem hiding this comment.
What's the reason for even doing it? Might it make more sense just to put src in the function declaration and omit the line altogether? It's not a breaking API change.
There was a problem hiding this comment.
@theckman Unfortunately, that would mean we lose consistency with the rest of the decodeX methods in that file, which all take a t []byte parameter.
FWIW, I have no opinion on this. I think the proposed change is fine as-is.
ghost
merged commit 
Drop unnecessary slice since type is already a slice.