Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use []bytes instead of strings in router #11

Closed
abahmed opened this issue May 10, 2020 · 0 comments · Fixed by #18
Closed

Use []bytes instead of strings in router #11

abahmed opened this issue May 10, 2020 · 0 comments · Fixed by #18
Assignees
@abahmed
Labels
enhancement New feature or request
Milestone
v1.0

Comments

@abahmed
Copy link
Member

abahmed commented May 10, 2020

Fasthttp recommends to avoid conversation between []byte and string.

We can avoid that in our routing process entirely. Through

  • update Ternary Search Tree to get and set keys in []byte
  • parsing and constructing routing tree in []byte not string
@abahmed abahmed added the enhancement New feature or request label May 10, 2020
@abahmed abahmed added this to the v1 milestone May 10, 2020
@muhammednagy muhammednagy self-assigned this May 10, 2020
@abahmed abahmed assigned abahmed and unassigned muhammednagy May 10, 2020
@raubrey2014 raubrey2014 mentioned this issue May 11, 2020
Closed
@abahmed abahmed mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abahmed abahmed

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Use []bytes instead of strings in router gogearbox/gearbox
2 participants
@abahmed @muhammednagy