Skip to content

enhance: change tracing span name from request uri to router uri for http request - #3338

Merged
gqcn merged 2 commits into
gogf:masterfrom
seth-shi:feature/tracing-uri
Mar 5, 2024
Merged

enhance: change tracing span name from request uri to router uri for http request#3338
gqcn merged 2 commits into
gogf:masterfrom
seth-shi:feature/tracing-uri

Conversation

@seth-shi

Copy link
Copy Markdown

update span name as route name, group route better than group request url

@seth-shi

Copy link
Copy Markdown
Author

url name:
11198d24d94d945b2810782ba66d436f

route name:
533817211a10fe6d63a0603447e6e891

@Issues-translate-bot

Copy link
Copy Markdown

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


url name:
11198d24d94d945b2810782ba66d436f

route name:
533817211a10fe6d63a0603447e6e891

@gqcn

gqcn commented Mar 4, 2024

Copy link
Copy Markdown
Member

@houseme @hailaz What do you guys think about this?

@gqcn
gqcn requested review from gqcn, hailaz and houseme March 4, 2024 12:41
@gqcn gqcn changed the title Feature/tracing uri enhance: change tracing span name from request uri to router uri for http request Mar 4, 2024
@houseme

houseme commented Mar 4, 2024

Copy link
Copy Markdown
Member

可以汇总到一起

@Issues-translate-bot

Copy link
Copy Markdown

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


can be summarized together

@mingzaily

Copy link
Copy Markdown
Member

有意思的pr

@Issues-translate-bot

Copy link
Copy Markdown

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Interesting PR

@gqcn
gqcn merged commit df15d70 into gogf:master Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants