Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in LDAP UTF-8 string decoding #916

Closed
lafriks opened this issue Feb 8, 2015 · 5 comments
Closed

Problem in LDAP UTF-8 string decoding #916

lafriks opened this issue Feb 8, 2015 · 5 comments
Labels
💊 bug Something isn't working

Comments

@lafriks
Copy link
Contributor

lafriks commented Feb 8, 2015

In file /modules/asn1-ber/ber.go function DecodeString code

    for _, c := range data {
        ret += fmt.Sprintf("%c", c)
    }

should be replaced with

    ret = string(data)

and then UTF-8 strings work correctly when coming from LDAP server.

@unknwon
Copy link
Member

unknwon commented Feb 8, 2015

Hi @lafriks , thanks your info!

Would you like to take this chance to make a PR, or I'll just make quick changes locally and push to GitHub?

@unknwon unknwon added the 💊 bug Something isn't working label Feb 8, 2015
@lafriks
Copy link
Contributor Author

lafriks commented Feb 8, 2015

just make changes yourself

@unknwon
Copy link
Member

unknwon commented Feb 8, 2015

Hi, I've pushed fix to dev branch.

@lafriks
Copy link
Contributor Author

lafriks commented Feb 9, 2015

Cool, thanks

@lafriks lafriks closed this as completed Feb 9, 2015
@unknwon
Copy link
Member

unknwon commented Feb 9, 2015

@lafriks no problem, thanks again for your help!

@unknwon unknwon removed the status: needs feedback Tell me more about it label Feb 9, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💊 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants