Image with link in markdown not working properly

[bouffa]

Hi,

Image links in markdown are not working properly. Sometimes, the link is replaced with the image url.

For example, this markdown command :
[![Project Stats](image_url)](link_url)

sometimes produces a link to image_url instead of link_url :

<a href=image_url><img src=image_url /> </a>

instead of

<a href=link_url><img src=image_url /> </a>

The problem can be reproduced on https://try.gogs.io (Gogs Version: 0.8.37.0215):

https://try.gogs.io/chengbs/Openfire/src/3.10/README.md

The link of the first badge (travis-ci) is correct, but the second (openhub badge) is linking to the gif image.

Thanks,

[unknwon]

Right now, only image path ends with .svg will produce a link to link, not image itself...

[MrDark]

Found the same problem in the latest develop build (0.9.12.0316)

Markdown:
[![Alt Text](http://image_url)](http://google.com)
Html:
<p><a href="http://google.com" rel="nofollow"></a><a href="http://image_url" rel="nofollow"><img src="http://image_url" alt="Alt Text"></a></p>

For full example:
https://try.gogs.io/Mr_Dark/Markdown-Test/src/master/README.md

[unknwon]

I think I said something very clear...

[DavidVentura]

I think the mimetype is wrong for svg images. When accessing a readme file with a linked svg image gogs offers a 'plain' file; even following the presented link just shows me the text because the mimetype is wrong

[strk]

Confirmed, this snippet also doesn't work on gogs:

[![build status]
(https://drone.osgeo.kbt.io/api/badges/geos/php-geos/status.svg?branch=master)]
(https://drone.osgeo.kbt.io/geos/php-geos?branch=master, alt=build status)

That is, it only produces the image, but not the link, as it should:

[](https://drone.osgeo.kbt.io/geos/php-geos?branch=master, alt=build status)

[strk]

@unknwon ending or not with .svg doesn't make a difference, see here:
https://try.gogs.io/strk/test1/issues/5

[strk]

Putting the image and link text onto the same line seems to fix the issue:

[![build status]
(https://drone.osgeo.kbt.io/api/badges/geos/php-geos/status.svg?branch=master)](https://drone.osgeo.kbt.io/geos/php-geos?branch=master, alt=build status)

[](https://drone.osgeo.kbt.io/geos/php-geos?branch=master, alt=build status)

This is not a problem on github.

[strk]

I was wrong, single-line doesn't fix it either:
https://try.gogs.io/strk/test1/issues/5#issuecomment-948

[drm]

@unknwon As I understand the rationale behind the code, it is there to have internally linked images being served from raw instead of src. But it also checks for links being absolute, i.e., have a protocol (validLinksPattern).

It seems to me that there are two issues here:

• the processing should only occur for internal links, i.e., links that match the current working tree, or at least only the gogs instance. Can you maybe write up a list of test cases that should work, as you probably know better what the original reasoning behind the code was?
• On the other hand, if the link already is inside an <a href...>...</a>, then it would not make sense processing it at all. That would probably be a more robust fix anyway. Maybe (r *Renderer) Image() can do a reverse scan on the output buffer to check if there is an unclosed a tag already in the buffer.

[strk]

Meanwhile I've figured my own issue, and filed it as #3545

[unknwon]

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io/gogs/gogs.

[unknwon]

Sorry, not develop branch, it's release/0.11.