New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone overview shows different number of closed issues/milestones #4316

Closed
arthur-bauer opened this Issue Mar 20, 2017 · 4 comments

Comments

2 participants
@arthur-bauer
Copy link

arthur-bauer commented Mar 20, 2017

  • Gogs version (or commit ref): 0.10.18
  • Git version: 2.7.4
  • Operating system: Ubuntu 16.04.2
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gogs.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist (usually found in log/gogs.log):

Description

The milestones overview shows a different amount of closed items than the actual milestone when you click on it.

It seems that, in the overview, gogs displays both closed issues and closed pull requests, but after clicking on the milestone, it displays only the number of closed issues. This should be handled consistently instead.

screen shot 2017-03-20 at 13 28 57

@Unknwon Unknwon added this to the 0.11 milestone Mar 20, 2017

Unknwon added a commit that referenced this issue Mar 24, 2017

@Unknwon

This comment has been minimized.

Copy link
Member

Unknwon commented Mar 24, 2017

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io.

@arthur-bauer

This comment has been minimized.

Copy link

arthur-bauer commented Mar 24, 2017

Opened and closed issues are now displayed correctly, but the green progress bar still counts issues and PR.

bildschirmfoto 2017-03-24 um 23 05 57

Link to testrepo

Unknwon added a commit that referenced this issue Mar 24, 2017

@Unknwon

This comment has been minimized.

Copy link
Member

Unknwon commented Mar 24, 2017

Good catch, please check demo site again.

@arthur-bauer

This comment has been minimized.

Copy link

arthur-bauer commented Mar 25, 2017

Looks good now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment