Fork/pull request public repostories #5

Closed
Unknwon opened this Issue Feb 14, 2014 · 87 comments

Comments

@Unknwon
Member

Unknwon commented Feb 14, 2014

  • Fork repostories
  • Pull request repostories

@Unknwon Unknwon added this to the Release 0.1 milestone Feb 14, 2014

@Unknwon Unknwon added the New Feature label Feb 14, 2014

@Unknwon Unknwon removed this from the Release 0.1 milestone Mar 6, 2014

@Unknwon Unknwon added this to the Release 0.2 milestone Mar 13, 2014

@fuxiaohei

This comment has been minimized.

Show comment
Hide comment
@fuxiaohei

fuxiaohei Mar 27, 2014

Contributor

Test comment

Contributor

fuxiaohei commented Mar 27, 2014

Test comment

@kureikain

This comment has been minimized.

Show comment
Hide comment
@kureikain

kureikain May 9, 2014

@Unknwon Does anyone work on this issue?

@Unknwon Does anyone work on this issue?

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon May 9, 2014

Member

We're discussing this in the dev group.

Member

Unknwon commented May 9, 2014

We're discussing this in the dev group.

@eryx

This comment has been minimized.

Show comment
Hide comment
@eryx

eryx Jul 8, 2014

Contributor

+1
Eagerly waiting for this feature

Contributor

eryx commented Jul 8, 2014

+1
Eagerly waiting for this feature

@jijinggang

This comment has been minimized.

Show comment
Hide comment
@jijinggang

jijinggang Jul 15, 2014

+1
It's important feature

+1
It's important feature

@stevenleeg

This comment has been minimized.

Show comment
Hide comment
@stevenleeg

stevenleeg Aug 24, 2014

⭐️

Super excited for this!

⭐️

Super excited for this!

@aarongreenlee

This comment has been minimized.

Show comment
Hide comment

@lunny lunny modified the milestones: Release v0.5.0, Release 0.2 Aug 30, 2014

@btilford

This comment has been minimized.

Show comment
Hide comment

btilford commented Sep 1, 2014

+1

@Unknwon Unknwon removed this from the Release v0.5.0 milestone Sep 1, 2014

@laurentdinclaux

This comment has been minimized.

Show comment
Hide comment
@tubia

This comment has been minimized.

Show comment
Hide comment

tubia commented Oct 18, 2014

  • 1
@none-da

This comment has been minimized.

Show comment
Hide comment

none-da commented Oct 31, 2014

👍

Unknwon added a commit that referenced this issue Nov 6, 2014

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Nov 6, 2014

Member

Update: master branch just pushed fork feature, PR is on the way!

Member

Unknwon commented Nov 6, 2014

Update: master branch just pushed fork feature, PR is on the way!

@eryx

This comment has been minimized.

Show comment
Hide comment
@eryx

eryx Nov 6, 2014

Contributor

👍

Contributor

eryx commented Nov 6, 2014

👍

@bradleypeabody

This comment has been minimized.

Show comment
Hide comment
@bradleypeabody

bradleypeabody Nov 7, 2014

+1 This (pull requests) would help adoption as well, since it's a key feature when you start dealing with a team of more than just a couple of people.

+1 This (pull requests) would help adoption as well, since it's a key feature when you start dealing with a team of more than just a couple of people.

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Nov 7, 2014

Member

@bradleypeabody you're absolutely right!

Member

Unknwon commented Nov 7, 2014

@bradleypeabody you're absolutely right!

@hugochinchilla

This comment has been minimized.

Show comment
Hide comment
@hugochinchilla

hugochinchilla Nov 26, 2014

+1 for pull requests

I have to choose between gitlab and gogs for managing repos at a company, if pull requests are going to be added soon gogs will be the winner.

+1 for pull requests

I have to choose between gitlab and gogs for managing repos at a company, if pull requests are going to be added soon gogs will be the winner.

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Nov 26, 2014

Member

@hugochinchilla we're working on PR right now, should be released in near future. But GitLab obviously has more features than Gogs at current stage, make the best choice is important, your option.

Member

Unknwon commented Nov 26, 2014

@hugochinchilla we're working on PR right now, should be released in near future. But GitLab obviously has more features than Gogs at current stage, make the best choice is important, your option.

@wangkuiyi

This comment has been minimized.

Show comment
Hide comment
@wangkuiyi

wangkuiyi Nov 27, 2014

+1 for Pull Request, so could we hope to replace Gitorious currently used in LinkedIn. Gitorious Merge Request feature sucks.

+1 for Pull Request, so could we hope to replace Gitorious currently used in LinkedIn. Gitorious Merge Request feature sucks.

@Techcable

This comment has been minimized.

Show comment
Hide comment
@Techcable

Techcable Dec 3, 2014

+1 for Pull Request
Needed to migrate private repos to gogs

+1 for Pull Request
Needed to migrate private repos to gogs

@sbditto85

This comment has been minimized.

Show comment
Hide comment
@sbditto85

sbditto85 Dec 5, 2014

+1 for Pull Requests

Awesome job btw!

+1 for Pull Requests

Awesome job btw!

@disassembler

This comment has been minimized.

Show comment
Hide comment
@disassembler

disassembler Dec 10, 2014

+1 for Pull Requests! Really looking forward to trying this once this functionality is added!

+1 for Pull Requests! Really looking forward to trying this once this functionality is added!

@michaeldyrynda

This comment has been minimized.

Show comment
Hide comment
@michaeldyrynda

michaeldyrynda Dec 24, 2014

Contributor

+1 for pull requests. We're using organisations / teams in the interim.

Contributor

michaeldyrynda commented Dec 24, 2014

+1 for pull requests. We're using organisations / teams in the interim.

@Nothing4You

This comment has been minimized.

Show comment
Hide comment

👍 PRs

@rojaro

This comment has been minimized.

Show comment
Hide comment
@rojaro

rojaro Jan 7, 2015

Contributor

+1

Contributor

rojaro commented Jan 7, 2015

+1

@izolate

This comment has been minimized.

Show comment
Hide comment
@izolate

izolate Jan 8, 2015

Eagerly waiting PRs. Thanks @Unknwon

izolate commented Jan 8, 2015

Eagerly waiting PRs. Thanks @Unknwon

@kageurufu

This comment has been minimized.

Show comment
Hide comment
@kageurufu

kageurufu Jan 29, 2015

👍 for sure

👍 for sure

@Xe

This comment has been minimized.

Show comment
Hide comment
@Xe

Xe Feb 12, 2015

Is there any update on this feature?

Xe commented Feb 12, 2015

Is there any update on this feature?

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Feb 12, 2015

Member

@Xe it's WIP, but recently we've received big PRs, so currently work on PRs, will get back when finish reviewing.

Member

Unknwon commented Feb 12, 2015

@Xe it's WIP, but recently we've received big PRs, so currently work on PRs, will get back when finish reviewing.

@Xe

This comment has been minimized.

Show comment
Hide comment
@Xe

Xe Feb 12, 2015

Can you post the code as is in a feature branch? I'd be happy to help test and fix it.

Xe commented Feb 12, 2015

Can you post the code as is in a feature branch? I'd be happy to help test and fix it.

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Feb 12, 2015

Member

@Xe We appreciate that! 👊 But we would like to fully on our own for the initial version 😄

Member

Unknwon commented Feb 12, 2015

@Xe We appreciate that! 👊 But we would like to fully on our own for the initial version 😄

@xaionaro

This comment has been minimized.

Show comment
Hide comment
@xaionaro

xaionaro Feb 18, 2015

Contributor

+1 for Pull Requests

Contributor

xaionaro commented Feb 18, 2015

+1 for Pull Requests

@galoppa

This comment has been minimized.

Show comment
Hide comment
@galoppa

galoppa Jun 29, 2015

@bartvankleef Somebody has finally forked it and I think they are working on both pull requests and wikis https://github.com/go-gitea/gitea

galoppa commented Jun 29, 2015

@bartvankleef Somebody has finally forked it and I think they are working on both pull requests and wikis https://github.com/go-gitea/gitea

@Unknwon Unknwon added this to the 0.6.7 milestone Aug 6, 2015

@liuyang1

This comment has been minimized.

Show comment
Hide comment
@liuyang1

liuyang1 Aug 28, 2015

+1, It's really good of gogs's easy deployment feature. But I need "Pull Request" feature. Without that, cannot use gogs in a large team.

+1, It's really good of gogs's easy deployment feature. But I need "Pull Request" feature. Without that, cannot use gogs in a large team.

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Aug 31, 2015

any news? :)

bastiao commented Aug 31, 2015

any news? :)

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Aug 31, 2015

Member

@bastiao almost :)

Member

Unknwon commented Aug 31, 2015

@bastiao almost :)

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 2, 2015

Member

OK, well. Hi all!

It's now able to test Pull Request on https://try.gogs.io/ . To keep your data safe and clean for future releases, please blow up it and post feedback here now! 😉

Member

Unknwon commented Sep 2, 2015

OK, well. Hi all!

It's now able to test Pull Request on https://try.gogs.io/ . To keep your data safe and clean for future releases, please blow up it and post feedback here now! 😉

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Sep 2, 2015

@Unknwon you're doing great!

bastiao commented Sep 2, 2015

@Unknwon you're doing great!

@xaionaro

This comment has been minimized.

Show comment
Hide comment
@xaionaro

xaionaro Sep 2, 2015

Contributor

A huge thanks!

Contributor

xaionaro commented Sep 2, 2015

A huge thanks!

@xaionaro

This comment has been minimized.

Show comment
Hide comment
@xaionaro

xaionaro Sep 2, 2015

Contributor

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

Contributor

xaionaro commented Sep 2, 2015

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 2, 2015

Member

Thank you for following up! @bastiao @xaionaro

@ALL: It's in very early stage, so... be nice... 👀

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

Yes, it will be added soon. I'm working on it.

Member

Unknwon commented Sep 2, 2015

Thank you for following up! @bastiao @xaionaro

@ALL: It's in very early stage, so... be nice... 👀

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

Yes, it will be added soon. I'm working on it.

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Sep 2, 2015

I'm updating my own installation and will test it properly. I will happy to return feedback too.

PS and offtopic: you should talk with people that fork gogs. It is not good to community to have disperse forks around. They was working on PR/forks too.

bastiao commented Sep 2, 2015

I'm updating my own installation and will test it properly. I will happy to return feedback too.

PS and offtopic: you should talk with people that fork gogs. It is not good to community to have disperse forks around. They was working on PR/forks too.

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Sep 2, 2015

# github.com/gogits/gogs/routers/api/v1
routers/api/v1/repo.go:105: opt.Gitignore undefined (type gogs.CreateRepoOption has no field or method Gitignore)
routers/api/v1/repo_hooks.go:29: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/repo_hooks.go:105: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/user.go:21: unknown gogs.User field 'Id' in struct literal

any idea why?

bastiao commented Sep 2, 2015

# github.com/gogits/gogs/routers/api/v1
routers/api/v1/repo.go:105: opt.Gitignore undefined (type gogs.CreateRepoOption has no field or method Gitignore)
routers/api/v1/repo_hooks.go:29: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/repo_hooks.go:105: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/user.go:21: unknown gogs.User field 'Id' in struct literal

any idea why?

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 2, 2015

Member

@bastiao

go get -u github.com/gogits/go-gogs-client

and then rebuild

Member

Unknwon commented Sep 2, 2015

@bastiao

go get -u github.com/gogits/go-gogs-client

and then rebuild

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Sep 2, 2015

@Unknwon great, thanks!

bastiao commented Sep 2, 2015

@Unknwon great, thanks!

@pcsch

This comment has been minimized.

Show comment
Hide comment
@pcsch

pcsch Sep 2, 2015

When opening a pull request the original repo gets a new open issue that is closed after merging.
This works for the issue view but in the overview for the original repo there is still one issue too much shown to be open. I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

e.g.:
When you had 10 open issues before the PR, you have 11 open after the PR, 10 open after merge but the overview still shows 11

(This was tested on try.gogs.io)

BTW: Thanks a lot for this feature.

pcsch commented Sep 2, 2015

When opening a pull request the original repo gets a new open issue that is closed after merging.
This works for the issue view but in the overview for the original repo there is still one issue too much shown to be open. I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

e.g.:
When you had 10 open issues before the PR, you have 11 open after the PR, 10 open after merge but the overview still shows 11

(This was tested on try.gogs.io)

BTW: Thanks a lot for this feature.

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Sep 2, 2015

@Unknwon the PR does not work inside the same repository. Only in forks?
I mean, it is useful in different branches of same repository.

bastiao commented Sep 2, 2015

@Unknwon the PR does not work inside the same repository. Only in forks?
I mean, it is useful in different branches of same repository.

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 2, 2015

Member

@bastiao right now, yes, only between forks(in same repo in the design though)

I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

@mexthemax good catch! Forgot that...

Member

Unknwon commented Sep 2, 2015

@bastiao right now, yes, only between forks(in same repo in the design though)

I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

@mexthemax good catch! Forgot that...

@Depado

This comment has been minimized.

Show comment
Hide comment
@Depado

Depado Sep 2, 2015

A friend of mine juste told me "Too bad it doesn't handle PRs". Went here. Saw the comment one hour ago saying it's now in test. Epic timing ! 💃

Depado commented Sep 2, 2015

A friend of mine juste told me "Too bad it doesn't handle PRs". Went here. Saw the comment one hour ago saying it's now in test. Epic timing ! 💃

@ALenfant

This comment has been minimized.

Show comment
Hide comment
@ALenfant

ALenfant Sep 2, 2015

I am the friend in question. I've wanted to switch to Gogs for so long but I needed PR support. I'm so happy, thanks guys! :D

ALenfant commented Sep 2, 2015

I am the friend in question. I've wanted to switch to Gogs for so long but I needed PR support. I'm so happy, thanks guys! :D

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 2, 2015

Member

@ALenfant hah, 😝

Note it's still early stage and may not as perfect as you expected. But I'm here to fix problems. 👀

Member

Unknwon commented Sep 2, 2015

@ALenfant hah, 😝

Note it's still early stage and may not as perfect as you expected. But I'm here to fix problems. 👀

@Unknwon Unknwon modified the milestone: 0.6.9 Sep 2, 2015

@zarezadeh

This comment has been minimized.

Show comment
Hide comment
@zarezadeh

zarezadeh Sep 3, 2015

A bug here: https://try.gogs.io/swordwinter/prtest/pulls there is two pull requests, one open and one closed. But when you click on open PR, it will show the close one. It seems both of them got same id

A bug here: https://try.gogs.io/swordwinter/prtest/pulls there is two pull requests, one open and one closed. But when you click on open PR, it will show the close one. It seems both of them got same id

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 3, 2015

Member

Thanks @zarezadeh ! I've pushed fix to try.gogs.io , and have fixed the index for your PR on the server :)

Member

Unknwon commented Sep 3, 2015

Thanks @zarezadeh ! I've pushed fix to try.gogs.io , and have fixed the index for your PR on the server :)

@zarezadeh

This comment has been minimized.

Show comment
Hide comment
@zarezadeh

zarezadeh Sep 3, 2015

Wow, that was fast, thanks.

Wow, that was fast, thanks.

@vijairaj

This comment has been minimized.

Show comment
Hide comment
@vijairaj

vijairaj Sep 3, 2015

This looks great! Waiting for this to get in to master.

vijairaj commented Sep 3, 2015

This looks great! Waiting for this to get in to master.

@bastiao

This comment has been minimized.

Show comment
Hide comment
@bastiao

bastiao Sep 3, 2015

If you can allow support of pull requests in the same project, between branches, it will be great!

bastiao commented Sep 3, 2015

If you can allow support of pull requests in the same project, between branches, it will be great!

@Unknwon Unknwon modified the milestones: 0.6.9, 0.7.0 Sep 5, 2015

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Sep 5, 2015

Member

OK, close right now.

Will open new issues for other specific needs.

Member

Unknwon commented Sep 5, 2015

OK, close right now.

Will open new issues for other specific needs.

@Unknwon Unknwon closed this Sep 5, 2015

@Unknwon Unknwon modified the milestone: 0.6.9 Sep 5, 2015

@Unknwon

This comment has been minimized.

Show comment
Hide comment
@Unknwon

Unknwon Oct 25, 2015

Member

Important update

I've pushed code to develop branch and https://try.gogs.io that check if pull request has conflict with upstream every time fork repository or upstream repository is pushed, so conflict will be detected correspondingly right now.

Leave feedback here so I can help with further problems you may encounter! 🍻

Member

Unknwon commented Oct 25, 2015

Important update

I've pushed code to develop branch and https://try.gogs.io that check if pull request has conflict with upstream every time fork repository or upstream repository is pushed, so conflict will be detected correspondingly right now.

Leave feedback here so I can help with further problems you may encounter! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment