Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to disabling federated avatar lookup #5126

Merged
merged 1 commit into from Mar 29, 2018

Conversation

2 participants
@9999years
Copy link
Contributor

9999years commented Mar 29, 2018

It's a fun feature but ENABLE_FEDERATED_AVATAR being true by default leads to confusion and huge slowdowns (see #2838, #980, #914) — it's unexpected that Gogs requires DNS configured (?) for avatars.

Avatar lookup is a niche feature that I don't believe should be enabled by default given how prone it is to causing problems.

Changes ENABLE_FEDERATED_AVATAR in conf/app.ini to be false.

Default to disabling federated avatar lookup
It's a fun feature but `ENABLE_FEDERATED_AVATAR` being true by default
leads to confusion and huge slowdowns (see #2838, #980, #914) --- it's
unexpected that Gogs requires DNS configured (?) for avatars.

Avatar lookup is a niche feature that I don't believe should be enabled
by default given how prone it is to causing problems.
@Unknwon

This comment has been minimized.

Copy link
Member

Unknwon commented Mar 29, 2018

Thank you!

@Unknwon Unknwon merged commit c3c7944 into gogs:develop Mar 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@9999years 9999years deleted the 9999years:develop branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.