Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rel="me" to website link on user profile #5485

Merged
merged 2 commits into from Nov 13, 2018

Conversation

@federicoculloca
Copy link
Contributor

@federicoculloca federicoculloca commented Oct 29, 2018

I added "me" to the value of the "rel" attribute on links pointing to a user's website, so this can be used for authentication in an IndieWeb context.

This targets issue #5008.

See issue #5008
@@ -31,7 +31,7 @@
{{if .Owner.Website}}
<li>
<i class="octicon octicon-link"></i>
<a target="_blank" rel="noopener noreferrer" href="{{.Owner.Website}}">{{.Owner.Website}}</a>
<a target="_blank" rel="noopener noreferrer me" href="{{.Owner.Website}}">{{.Owner.Website}}</a>

This comment has been minimized.

@unknwon

unknwon Nov 5, 2018
Member

Should we add "nofollow" as well as suggested in #5008?

This comment has been minimized.

@federicoculloca

federicoculloca Nov 12, 2018
Author Contributor

Sorry for the delay. Done :)

@unknwon
Copy link
Member

@unknwon unknwon commented Nov 13, 2018

Thank you!

@unknwon unknwon merged commit 81effe6 into gogs:develop Nov 13, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mro
Copy link

@mro mro commented Nov 17, 2018

Thanks a lot, @federicoculloca !

@federicoculloca federicoculloca deleted the federicoculloca:patch-1 branch Nov 17, 2018
crohr added a commit to pkgr/gogs that referenced this pull request Jan 31, 2019
gogs#5485)

* Added rel="me" to website link on user profile

See issue gogs#5008

* Added `nofollow` as per feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.