Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rel="me" to website link on user profile #5485

Merged
merged 2 commits into from Nov 13, 2018

Conversation

federicoculloca
Copy link
Contributor

I added "me" to the value of the "rel" attribute on links pointing to a user's website, so this can be used for authentication in an IndieWeb context.

This targets issue #5008.

@@ -31,7 +31,7 @@
{{if .Owner.Website}}
<li>
<i class="octicon octicon-link"></i>
<a target="_blank" rel="noopener noreferrer" href="{{.Owner.Website}}">{{.Owner.Website}}</a>
<a target="_blank" rel="noopener noreferrer me" href="{{.Owner.Website}}">{{.Owner.Website}}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add "nofollow" as well as suggested in #5008?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Done :)

@unknwon unknwon added the status: needs feedback Tell me more about it label Nov 5, 2018
@unknwon unknwon removed the status: needs feedback Tell me more about it label Nov 13, 2018
@unknwon
Copy link
Member

unknwon commented Nov 13, 2018

Thank you!

@unknwon unknwon merged commit 81effe6 into gogs:develop Nov 13, 2018
@mro
Copy link

mro commented Nov 17, 2018

Thanks a lot, @federicoculloca !

@federicoculloca federicoculloca deleted the patch-1 branch November 17, 2018 19:57
crohr pushed a commit to pkgr/gogs that referenced this pull request Jan 31, 2019
gogs#5485)

* Added rel="me" to website link on user profile

See issue gogs#5008

* Added `nofollow` as per feedback
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants