Skip to content

Added rel="me" to website link on user profile#5485

Merged
unknwon merged 2 commits into
gogs:developfrom
federicoculloca:patch-1
Nov 13, 2018
Merged

Added rel="me" to website link on user profile#5485
unknwon merged 2 commits into
gogs:developfrom
federicoculloca:patch-1

Conversation

@federicoculloca

Copy link
Copy Markdown
Contributor

I added "me" to the value of the "rel" attribute on links pointing to a user's website, so this can be used for authentication in an IndieWeb context.

This targets issue #5008.

Comment thread templates/user/profile.tmpl Outdated
<li>
<i class="octicon octicon-link"></i>
<a target="_blank" rel="noopener noreferrer" href="{{.Owner.Website}}">{{.Owner.Website}}</a>
<a target="_blank" rel="noopener noreferrer me" href="{{.Owner.Website}}">{{.Owner.Website}}</a>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add "nofollow" as well as suggested in #5008?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Done :)

@unknwon unknwon added the status: needs feedback Tell me more about it label Nov 5, 2018
@unknwon unknwon removed the status: needs feedback Tell me more about it label Nov 13, 2018
@unknwon

unknwon commented Nov 13, 2018

Copy link
Copy Markdown
Member

Thank you!

@unknwon unknwon merged commit 81effe6 into gogs:develop Nov 13, 2018
@mro

mro commented Nov 17, 2018

Copy link
Copy Markdown

Thanks a lot, @federicoculloca !

@federicoculloca federicoculloca deleted the patch-1 branch November 17, 2018 19:57
crohr pushed a commit to pkgr/gogs that referenced this pull request Jan 31, 2019
gogs#5485)

* Added rel="me" to website link on user profile

See issue gogs#5008

* Added `nofollow` as per feedback
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants