Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing typo '}' from ingress.annotations default #415

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@bgulla
Copy link
Contributor

bgulla commented Oct 25, 2019

Editing{}} to {} for the default annotation value.

@bgulla bgulla closed this Oct 25, 2019
@bgulla bgulla reopened this Oct 25, 2019
@ywk253100

This comment has been minimized.

Copy link
Collaborator

ywk253100 commented Oct 29, 2019

@bgulla Could you fix the DCO error?

@ywk253100

This comment has been minimized.

Copy link
Collaborator

ywk253100 commented Nov 1, 2019

@bgulla ping

Editing`{}}` to `{}` for the default annotation value.

Signed-off-by: 591075 <brandongulla@C02Z90X2LVDT.local>
@bgulla bgulla force-pushed the bgulla:master branch from 6894c35 to 2b48284 Nov 1, 2019
@bgulla

This comment has been minimized.

Copy link
Contributor Author

bgulla commented Nov 1, 2019

@bgulla ping

fixed.

@ywk253100 ywk253100 merged commit 3eabcbc into goharbor:master Nov 5, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.