Two minor typos in Makefile #12259
Labels
Comments
cafeliker
pushed a commit
to cafeliker/harbor
that referenced
this issue
Jul 14, 2020
Fix goharbor#12259 Signed-off-by: Max Rosin <git@hackrid.de> Signed-off-by: Ye Liu <ye.liu@hp.com>
bmfp
pushed a commit
to bmfp/harbor
that referenced
this issue
Jul 22, 2020
Fix goharbor#12259 Signed-off-by: Max Rosin <git@hackrid.de> Signed-off-by: molinber <bertrand.molin@credit-agricole.net>
tedgxt
pushed a commit
to tedgxt/harbor
that referenced
this issue
Aug 11, 2020
Fix goharbor#12259 Signed-off-by: Max Rosin <git@hackrid.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior and actual behavior:
Variables in the Makefile should have correct names.
Steps to reproduce the problem:
Search for
DOCKERIMASESandSWAAGER_IMAGE_BUILD_CMDin the Makefile.Versions:
Master branch of the repo.
Additional context:
I searched the repo and as far as I understand this should not interfere with anything else. I found the same
DOCKERIMASESin the Makefile of photon and fixed it there but I think that isn't even used anywhere.I am going to create a PR in a minute.
The text was updated successfully, but these errors were encountered: