Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker registry not supporting GCS #6959

Closed
paulczar opened this issue Feb 18, 2019 · 7 comments
Closed

docker registry not supporting GCS #6959

paulczar opened this issue Feb 18, 2019 · 7 comments
Assignees

Comments

@paulczar
Copy link
Contributor

@paulczar paulczar commented Feb 18, 2019

Expected: Docker registry should support GCS as a storage option.

Actual:
time="2019-02-18T16:37:52.076033578Z" level=info msg="debug server listening localhost:5001"
panic: StorageDriver not registered: gcs

This is using the dev images. with a bit of digging I think the wrong environment variables are being used to pass the build details to incude GCS.

In the docker registry makefile it has:

GO_TAGS=$(if $(BUILDTAGS),-tags "$(BUILDTAGS)",)

in the build scripts in harbor:

ENV DOCKER_BUILDTAGS include_oss include_gcs

I believe the latter needs to be set to ENV BUILDTAGS include_oss include_gcs

paulczar added a commit to paulczar/harbor that referenced this issue Feb 18, 2019
this should address goharbor#6959

Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
@reasonerjt

This comment has been minimized.

Copy link
Contributor

@reasonerjt reasonerjt commented Feb 21, 2019

@paulczar Are you using Harbor tile? Could you let us know the version?

@wy65701436 I believe we tested it? Could you double check?

@reasonerjt reasonerjt added the kind/bug label Feb 21, 2019
@stonezdj

This comment has been minimized.

Copy link
Contributor

@stonezdj stonezdj commented Feb 21, 2019

The docker registry used by harbor tile 1.6.0 is v2.6.2, in branch release/2.6, makefile: the env for build flag is still DOCKER_BUILDTAGS. build flag should not be the root cause.

I manually verified upload images to harbor tile instance with gcs storage, and can not reproduce this issue.

@stonezdj

This comment has been minimized.

Copy link
Contributor

@stonezdj stonezdj commented Feb 21, 2019

@paulczar the log is from the dev image of registry? not the image
46245b5ebbcd goharbor/registry-photon:v2.6.2-v1.6.0

@wy65701436

This comment has been minimized.

Copy link
Contributor

@wy65701436 wy65701436 commented Feb 21, 2019

@paulczar it's a bug of registry v2.7.1, it will be fixed in v2.7.2.

We'll bump up to v2.7.2 once it's released, just keep this issue open.

@paulczar

This comment has been minimized.

Copy link
Contributor Author

@paulczar paulczar commented Mar 2, 2019

Thanks, Sorry for the long delay. This is trying to use the Helm Charts rather than the tile.

@paulczar

This comment has been minimized.

Copy link
Contributor Author

@paulczar paulczar commented Mar 2, 2019

I can confirm when I switch the image tags in helm chart from dev to v1.7.1 this started working again.

@wy65701436

This comment has been minimized.

Copy link
Contributor

@wy65701436 wy65701436 commented Apr 11, 2019

I have updated the registry binary to v2.7.1-path-2819, which contains the fix of GCS storage driver issue.

@wy65701436 wy65701436 closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.