Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOCKERIMASES and SWAAGER_IMAGE_BUILD_CMD typos in Makefiles #12260

Merged
merged 1 commit into from Jun 22, 2020
Merged

Fix DOCKERIMASES and SWAAGER_IMAGE_BUILD_CMD typos in Makefiles #12260

merged 1 commit into from Jun 22, 2020

Conversation

ekeih
Copy link
Contributor

@ekeih ekeih commented Jun 16, 2020

Fix #12259

Signed-off-by: Max Rosin git@hackrid.de

Fix #12259

Signed-off-by: Max Rosin <git@hackrid.de>
@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #12260 into master will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12260      +/-   ##
==========================================
+ Coverage   55.77%   56.96%   +1.18%     
==========================================
  Files         918      650     -268     
  Lines       53301    40909   -12392     
  Branches     1798        0    -1798     
==========================================
- Hits        29731    23305    -6426     
+ Misses      20250    14878    -5372     
+ Partials     3320     2726     -594     
Flag Coverage Δ
#unittests 56.96% <ø> (+1.18%) ⬆️
Impacted Files Coverage Δ
...harbor/harbor/src/portal/src/app/log/log.module.ts
...te-edit-endpoint/create-edit-endpoint.component.ts
...bor/harbor/src/portal/src/app/user/user.service.ts
...rc/portal/src/app/user/new-user-modal.component.ts
...pp/shared/new-user-form/new-user-form.component.ts
...ortal/src/app/account/sign-up/sign-up.component.ts
...src/portal/src/lib/services/system-info.service.ts
...nents/third-party/ngx-window-token/window-token.ts
...ry/artifact/artifact-tag/artifact-tag.component.ts
...c/portal/src/app/global-message/message.service.ts
... and 260 more

Copy link
Member

@ninjadq ninjadq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ninjadq ninjadq merged commit d413fc0 into goharbor:master Jun 22, 2020
2 checks passed
@ekeih ekeih deleted the 12259-two-minor-typos-in-makefile branch June 22, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two minor typos in Makefile
3 participants