New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cache layer for artifact #16593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16593 +/- ##
==========================================
+ Coverage 67.29% 67.35% +0.06%
==========================================
Files 953 956 +3
Lines 79048 79191 +143
Branches 2332 2332
==========================================
+ Hits 53195 53340 +145
+ Misses 22279 22248 -31
- Partials 3574 3603 +29
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
force-pushed
the
feat/cache-layer-for-artifact
branch
3 times, most recently
from
March 30, 2022 07:17
b984352
to
0da476b
Compare
wy65701436
reviewed
Mar 31, 2022
stonezdj
reviewed
Apr 6, 2022
stonezdj
reviewed
Apr 6, 2022
stonezdj
reviewed
Apr 6, 2022
stonezdj
approved these changes
Apr 15, 2022
chlins
force-pushed
the
feat/cache-layer-for-artifact
branch
from
April 19, 2022 08:35
0da476b
to
4a1d25b
Compare
chlins
force-pushed
the
feat/cache-layer-for-artifact
branch
3 times, most recently
from
April 19, 2022 10:05
8be884b
to
cab8fd9
Compare
wy65701436
reviewed
Apr 20, 2022
wy65701436
reviewed
Apr 20, 2022
wy65701436
reviewed
Apr 20, 2022
wy65701436
reviewed
Apr 20, 2022
wy65701436
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
chlins
force-pushed
the
feat/cache-layer-for-artifact
branch
2 times, most recently
from
April 22, 2022 10:11
3e283d8
to
814290c
Compare
stonezdj
reviewed
Apr 25, 2022
Implement cache layer for resource artifact and define common cache manager and workflow. Also add cache related options to configuration yaml. Signed-off-by: chlins <chenyuzh@vmware.com>
chlins
force-pushed
the
feat/cache-layer-for-artifact
branch
from
April 25, 2022 10:04
814290c
to
8c22313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement cache layer for resource artifact and define common
cache manager and workflow. Also add cache related options to
configuration yaml.
Closes: #16739
Signed-off-by: chlins chenyuzh@vmware.com
Comparison
Get the specific artifact
/projects/{project_name}/repositories/{repository_name}/artifacts/{reference}
Get by digest
script:
hey -c 2000 -z 1m -H "Authorization: Basic YWRtaW46SGFyYm9yMTIzNDUK" http://harbor.domain/api/v2.0/projects/library/repositories/busybox/artifacts/sha256:14d4f50961544fdb669075c442509f194bdc4c0e344bde06e35dbd55af842a38
2.5:
after:
In conclusion, QPS improvement is about 3.8X and P99 latency is 2.8X faster than 2.5.
Get by tag
script:
hey -c 2000 -z 1m -H "Authorization: Basic YWRtaW46SGFyYm9yMTIzNDUK" http://harbor.domain/api/v2.0/projects/library/repositories/busybox/artifacts/latest
2.5:
after:
In conclusion, QPS improvement is about 1.4X and P99 latency is 1.8X faster than 2.5, and also success rate improve to 100%.