Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow creating an admin user when registration #8917

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@reasonerjt
Copy link
Contributor

commented Sep 2, 2019

This commit enhance the POST /api/users API to block request from non-admin to create
admin user.

Signed-off-by: Daniel Jiang jiangd@vmware.com

This commit enhance the `POST /api/users` API to block request from non-admin to create
admin user.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>
Copy link
Contributor

left a comment

lgtm

@coveralls

This comment has been minimized.

Copy link

commented Sep 2, 2019

Pull Request Test Coverage Report for Build 15143

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 66.183%

Totals Coverage Status
Change from base Build 15139: 0.006%
Covered Lines: 22133
Relevant Lines: 33442

💛 - Coveralls
@ywk253100 ywk253100 merged commit 7d15194 into goharbor:master Sep 2, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Copy link
Contributor

left a comment

LGTM

@aviv320i aviv320i referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.