Permalink
Browse files

Fix bug in Site.assembleSections method

Site.assembleSections logic assumes that the the home page would always be the first in the Site's list of pages. This is not in fact guaranteed to be true. When it is not, the method can fail to set the parent for some or all root-level pages. 

Fixes #4447
  • Loading branch information...
vassudanagunta authored and bep committed Feb 25, 2018
1 parent e9750d8 commit 00868081f624928d773a7b698654766f8cd70069
Showing with 7 additions and 3 deletions.
  1. +7 −3 hugolib/site_sections.go
View
@@ -167,11 +167,15 @@ func (s *Site) assembleSections() Pages {
undecided Pages
)
homes := s.findPagesByKind(KindHome)
if len(homes) == 1 {
home = homes[0]
} else if len(homes) > 1 {
panic("Too many homes")
}
for i, p := range s.Pages {
if p.Kind != KindPage {
if p.Kind == KindHome {
home = p
}
continue
}

0 comments on commit 0086808

Please sign in to comment.