Skip to content
Permalink
Browse files

tpl: Last now accepts 0 as limit

Modified the if conditional because of which last threw an error if 0 was passed as limit. The function now returns an empty slice if it is called with 0 as limit. The behavior of first and last is now the same when 0 is passed as limit. Also added tests to test the new behavior.

Fixes #6419
  • Loading branch information...
BaibhaVatsa authored and bep committed Oct 11, 2019
1 parent 5f1aafa commit 0e75af74db30259ec355a7b79a1e257d5fe00eef
Showing with 3 additions and 1 deletion.
  1. +1 −1 tpl/collections/collections.go
  2. +2 −0 tpl/collections/collections_test.go
@@ -378,7 +378,7 @@ func (ns *Namespace) Last(limit interface{}, seq interface{}) (interface{}, erro
return nil, err
}

if limitv < 1 {
if limitv < 0 {
return nil, errors.New("can't return negative/empty count of items from sequence")
}

@@ -495,6 +495,8 @@ func TestLast(t *testing.T) {
{int64(2), []int{100, 200, 300}, []int{200, 300}},
{100, []int{100, 200}, []int{100, 200}},
{"1", []int{100, 200, 300}, []int{300}},
{"0", []int{100, 200, 300}, []int{}},
{"0", []string{"a", "b", "c"}, []string{}},
// errors
{int64(-1), []int{100, 200, 300}, false},
{"noint", []int{100, 200, 300}, false},

0 comments on commit 0e75af7

Please sign in to comment.
You can’t perform that action at this time.