Permalink
Browse files

hugolib: Allow nil to be unwrapped as *Page

Previously, calls to *Page.Eq(nil) would always return false because the
unwrapPage func didn't support the nil case.  Add support for unwrapping
nil to a *Page.

Fixes #5043
  • Loading branch information...
moorereason authored and bep committed Oct 3, 2018
1 parent 10ac2ec commit 498d6299581bead0f582431b8133d8b5f8760618
Showing with 7 additions and 0 deletions.
  1. +2 −0 hugolib/site_sections.go
  2. +5 −0 hugolib/site_sections_test.go
@@ -152,6 +152,8 @@ func unwrapPage(in interface{}) (*Page, error) {
return v.Page, nil
case *PageWithoutContent:
return v.Page, nil
case nil:
return nil, nil
default:
return nil, fmt.Errorf("%T not supported", in)
}
@@ -166,6 +166,11 @@ PAG|{{ .Title }}|{{ $sect.InSection . }}
assert.Equal("empty3.md", b.Pages[0].File.LogicalName())
}},
{"empty3", func(p *Page) {
xxx := p.s.getPage(KindPage, "empty3", "nil")
assert.Nil(xxx)
assert.Equal(xxx.Eq(nil), true)
}},
{"top", func(p *Page) {
assert.Equal("Tops", p.title)
assert.Len(p.Pages, 2)

0 comments on commit 498d629

Please sign in to comment.