Skip to content
Permalink
Browse files

commands: Fix config reloading in Vim and similar

The config path was simplified in Hugo 0.56.0 to support more config dirs/files (go.mod etc.),
and the new code path assumed that every file change would trigger a `Write` event.

This is not true for Vim etc. which triggers a `Chmod` and then a `Rename`.

Lesson learned: Be really careful changing Os/editor specific code without proper tests.

Fixes #6139
  • Loading branch information...
bep committed Jul 30, 2019
1 parent e28bd4c commit 6eca0a3dee77f0e764b1de2e10c10ec2b7cf8ef1
Showing with 2 additions and 2 deletions.
  1. +2 −2 commands/hugo.go
@@ -914,12 +914,12 @@ func (c *commandeer) handleEvents(watcher *watcher.Batcher,
}
}

// A write event will follow.
continue
}

// Config file(s) changed. Need full rebuild.
c.fullRebuild(configChangeType)

return
}
}

0 comments on commit 6eca0a3

Please sign in to comment.
You can’t perform that action at this time.