Skip to content
Permalink
Browse files

resources/page: Re-introduce .Page.Page

It was removed in 597e418 -- it's not documented, but it's used in too many real sites on the web.

See #5784
  • Loading branch information...
bep committed Mar 25, 2019
1 parent b5f39d2 commit 91ef9655aaf2adea3a044bf9a464908084917a98
@@ -104,6 +104,10 @@ func (pt pageTree) InSection(other interface{}) (bool, error) {

}

func (pt pageTree) Page() page.Page {
return pt.p
}

func (pt pageTree) Parent() page.Page {
return pt.p.parent
}
@@ -340,6 +340,10 @@ type TreeProvider interface {
// Sections returns this section's subsections, if any.
// Note that for non-sections, this method will always return an empty list.
Sections() Pages

// Page returns a reference to the Page itself, kept here mostly
// for legacy reasons.
Page() Page
}

// DeprecatedWarningPageMethods lists deprecated Page methods that will trigger
@@ -107,7 +107,12 @@ func generateMarshalJSON(c *codegen.Inspector) error {
return errors.New("no methods found")
}

marshalJSON, pkgImports := methods.ToMarshalJSON("Page", "github.com/gohugoio/hugo/resources/page")
marshalJSON, pkgImports := methods.ToMarshalJSON(
"Page",
"github.com/gohugoio/hugo/resources/page",
// Exclusion regexps. Matches method names.
`\bPage\b`,
)

fmt.Fprintf(f, `%s
@@ -299,6 +299,10 @@ func (p *nopPage) Params() map[string]interface{} {
return nil
}

func (p *nopPage) Page() Page {
return p
}

func (p *nopPage) Parent() Page {
return nil
}
@@ -360,6 +360,10 @@ func (p *testPage) Params() map[string]interface{} {
return p.params
}

func (p *testPage) Page() Page {
return p
}

func (p *testPage) Parent() Page {
panic("not implemented")
}

0 comments on commit 91ef965

Please sign in to comment.
You can’t perform that action at this time.