Support themesDir option #1556

Closed
SebastianM opened this Issue Nov 7, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@SebastianM
Contributor

SebastianM commented Nov 7, 2015

I would like to configure where my themes are located. Currently the "themes" dir name is hardcoded (path.go#L213) and not configurable. My proposal is to add a themesDir option (in addition to dataDir, staticDir, etc.):

themesDir: 'assets/docs/themes'
theme: 'myTheme'

In this case, hugo would use asset/docs/themes/myTheme as the theme folder.

@spf13

This comment has been minimized.

Show comment
Hide comment
@spf13

spf13 Nov 7, 2015

Contributor

Great idea. Do you want to code it?

Contributor

spf13 commented Nov 7, 2015

Great idea. Do you want to code it?

@SebastianM

This comment has been minimized.

Show comment
Hide comment
@SebastianM

SebastianM Nov 7, 2015

Contributor

I'm not familiar with the codebase but I will try :-)

Contributor

SebastianM commented Nov 7, 2015

I'm not familiar with the codebase but I will try :-)

@bep bep changed the title from Proposal - Support themesDir option to Support themesDir option Nov 7, 2015

@bep bep added the Enhancement label Nov 7, 2015

@AldenJole

This comment has been minimized.

Show comment
Hide comment
@AldenJole

AldenJole Nov 29, 2015

It seems like it might be more useful to just have a themePath option. Then I could use it like hugo server --themePath . --source exampleSite during theme development.

It seems like it might be more useful to just have a themePath option. Then I could use it like hugo server --themePath . --source exampleSite during theme development.

@spf13

This comment has been minimized.

Show comment
Hide comment
@spf13

spf13 Nov 29, 2015

Contributor

@AldenJole I like that idea as well. Not sure which one is better. Probably yours, it's simpler. Is there a valid use case for the themeDir approach if we have themePath?

Contributor

spf13 commented Nov 29, 2015

@AldenJole I like that idea as well. Not sure which one is better. Probably yours, it's simpler. Is there a valid use case for the themeDir approach if we have themePath?

@AldenJole

This comment has been minimized.

Show comment
Hide comment
@AldenJole

AldenJole Nov 29, 2015

Eventually we might be able to replace the whole themeDir concept with themePath and then just put them in themes by convention. Then the config option would look like theme = "themes/<theme-name>". That would also give use the ability to specify remote themes, e.g., github projects.

Eventually we might be able to replace the whole themeDir concept with themePath and then just put them in themes by convention. Then the config option would look like theme = "themes/<theme-name>". That would also give use the ability to specify remote themes, e.g., github projects.

@spf13

This comment has been minimized.

Show comment
Hide comment
@spf13

spf13 Nov 29, 2015

Contributor

I agree. I like this much better.

Steve Francia
http://stevefrancia.com
http://spf13.com
http://twitter.com/spf13

On Sun, Nov 29, 2015 at 12:35 PM, Alden Jole notifications@github.com
wrote:

Eventually we might be able to replace the whole themeDir concept with
themePath and then just put them in themes by convention. Then the config
option would look like theme = "themes/". That would also
give use the ability to specify remote themes, e.g., github projects.


Reply to this email directly or view it on GitHub
#1556 (comment).

Contributor

spf13 commented Nov 29, 2015

I agree. I like this much better.

Steve Francia
http://stevefrancia.com
http://spf13.com
http://twitter.com/spf13

On Sun, Nov 29, 2015 at 12:35 PM, Alden Jole notifications@github.com
wrote:

Eventually we might be able to replace the whole themeDir concept with
themePath and then just put them in themes by convention. Then the config
option would look like theme = "themes/". That would also
give use the ability to specify remote themes, e.g., github projects.


Reply to this email directly or view it on GitHub
#1556 (comment).

@AldenJole

This comment has been minimized.

Show comment
Hide comment
@AldenJole

AldenJole Nov 29, 2015

We might be able to figure out a reasonable way to parse the theme option to figure out if it's a path or not.

We might be able to figure out a reasonable way to parse the theme option to figure out if it's a path or not.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Dec 22, 2016

Member

Fixed by #2817

Member

moorereason commented Dec 22, 2016

Fixed by #2817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment