Stable .ByCount index sort? #1930

Closed
frioux opened this Issue Mar 7, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@frioux

frioux commented Mar 7, 2016

Currently the .ByCount sorter for indices does not order things reliably within a given count. This means that every time I make a build my index of tags changes order. It's not a huge deal but it's sortav annoying and adding a secondary sort seems like it would only help. I could probably draft a patch but I wanted to verify that others are interested first.

@bep bep added the Enhancement label Mar 7, 2016

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 7, 2016

Member

Patch is welcomed.

Member

bep commented Mar 7, 2016

Patch is welcomed.

@frioux

This comment has been minimized.

Show comment
Hide comment
@frioux

frioux Mar 7, 2016

Cool. I just upgraded to 0.15 and I think this was resolved without any kind of mention in the Changelog. I'll verify and then close.

frioux commented Mar 7, 2016

Cool. I just upgraded to 0.15 and I think this was resolved without any kind of mention in the Changelog. I'll verify and then close.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

@frioux have you checked?

Member

bep commented Mar 11, 2016

@frioux have you checked?

@frioux

This comment has been minimized.

Show comment
Hide comment
@frioux

frioux Mar 11, 2016

Yeah, sadly the issue does still exist. I am not sure why it varied from
one system to the next. I still would like to send a patch but if I don't
get around to it it seems like good low hanging fruit.

On Fri, Mar 11, 2016 at 8:05 AM, Bjørn Erik Pedersen <
notifications@github.com> wrote:

@frioux https://github.com/frioux have you checked?


Reply to this email directly or view it on GitHub
#1930 (comment).

fREW Schmidt
http://blog.afoolishmanifesto.com

frioux commented Mar 11, 2016

Yeah, sadly the issue does still exist. I am not sure why it varied from
one system to the next. I still would like to send a patch but if I don't
get around to it it seems like good low hanging fruit.

On Fri, Mar 11, 2016 at 8:05 AM, Bjørn Erik Pedersen <
notifications@github.com> wrote:

@frioux https://github.com/frioux have you checked?


Reply to this email directly or view it on GitHub
#1930 (comment).

fREW Schmidt
http://blog.afoolishmanifesto.com

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Mar 11, 2016

Member

A patch would be great, but a test case that could be added to hugolib/taxonomy_test.go would be helpful, too. We clearly need more tests for the taxonomies.

Member

moorereason commented Mar 11, 2016

A patch would be great, but a test case that could be added to hugolib/taxonomy_test.go would be helpful, too. We clearly need more tests for the taxonomies.

robertbasic added a commit to robertbasic/hugo that referenced this issue Apr 1, 2016

Make ByCount sort consistently
When two or more taxonomies have the same number of pages,
sort them by name to have consistent ByCount sorting of
taxonomies.

Fixes #1930

@bep bep closed this in 7d5c9fb Apr 2, 2016

tychoish added a commit to tychoish/hugo that referenced this issue Aug 13, 2017

Make ByCount sort consistently
When two or more taxonomies have the same number of pages,
sort them by name to have consistent ByCount sorting of
taxonomies.

Fixes #1930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment