New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Emoji not parsed on certain text patterns #2198

Closed
revelt opened this Issue Jun 11, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@revelt
Contributor

revelt commented Jun 11, 2016

Hi all,

There is a bug in the emoji rendering, probably related to #1892. My post content with emoji is sometimes parsed, sometimes not, and I distilled the following:

  • Emoji are not parsed when the colon character is being present
  • If the text after comma is short enough, emoji renders fine, no matter is there a colon or not

See this:
hugo-emoji-bug

Try copy-pasting into your sites to test:

Aaaaaaaaaa: aaaaaaaaaa aaaaaaaaaa aaaaaaaaaa.

:rocket:

In practice, my blog articles contain some colon characters and emoji are not being parsed on the whole article. By the way, I'm using the latest Hugo v0.16 from Brew.

@memiks

This comment has been minimized.

Show comment
Hide comment
@memiks

memiks Jul 1, 2016

Hello,

Ok but I try my text with master source code without success...
After the merge of your commit.

You can test if you want.

Best regards,
Memiks.

memiks commented Jul 1, 2016

Hello,

Ok but I try my text with master source code without success...
After the merge of your commit.

You can test if you want.

Best regards,
Memiks.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jul 1, 2016

Member

I did: aa66478

Are you saying there are other failing test cases?

Member

bep commented Jul 1, 2016

I did: aa66478

Are you saying there are other failing test cases?

@revelt

This comment has been minimized.

Show comment
Hide comment
@revelt

revelt Jul 1, 2016

Contributor

I'd help testing, but I'm not good at compiling. I'm still at 0.16 first release...

Contributor

revelt commented Jul 1, 2016

I'd help testing, but I'm not good at compiling. I'm still at 0.16 first release...

tychoish added a commit to tychoish/hugo that referenced this issue Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment