New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero Weight should not be considered in page sorting #2673

Closed
bep opened this Issue Nov 6, 2016 · 5 comments

Comments

Projects
None yet
4 participants

@bep bep added the Bug label Nov 6, 2016

@bep bep added this to the v0.18 milestone Nov 6, 2016

@bep bep closed this in 4b4ab47 Nov 6, 2016

@lexingxie

This comment has been minimized.

Show comment
Hide comment
@lexingxie

lexingxie Jan 5, 2017

Unweighted pages should have a default weight (e.g. 0), and then the sorting should be consistent for promoting and demoting pages.

This would be consistent if the sorting is descending according to weight
-- i.e. putting a positive weight promotes a page, a negative weight demotes a page.

lexingxie commented Jan 5, 2017

Unweighted pages should have a default weight (e.g. 0), and then the sorting should be consistent for promoting and demoting pages.

This would be consistent if the sorting is descending according to weight
-- i.e. putting a positive weight promotes a page, a negative weight demotes a page.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jan 5, 2017

Member

I agree, but that would break stuff.

Member

bep commented Jan 5, 2017

I agree, but that would break stuff.

@erkanerol

This comment has been minimized.

Show comment
Hide comment
@erkanerol

erkanerol Feb 7, 2017

It was not a bug, it was a feature 👎
I gave set some huge values to some posts' weight to send them at the bottom of the list. Now, they are at the top. Do I need to set weight for all other posts?

erkanerol commented Feb 7, 2017

It was not a bug, it was a feature 👎
I gave set some huge values to some posts' weight to send them at the bottom of the list. Now, they are at the top. Do I need to set weight for all other posts?

@shmel210

This comment has been minimized.

Show comment
Hide comment
@shmel210

shmel210 Feb 10, 2017

this commit (4b4ab47) breaks expected sorting.

{{ range .Data.Pages.ByWeight.Reverse }}
output: 0 0 20161200 20161000 450 100 50 10

output expected: 20161200 20161000 450 100 50 10 0 0

shmel210 commented Feb 10, 2017

this commit (4b4ab47) breaks expected sorting.

{{ range .Data.Pages.ByWeight.Reverse }}
output: 0 0 20161200 20161000 450 100 50 10

output expected: 20161200 20161000 450 100 50 10 0 0

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Feb 10, 2017

Member

Please don't comment on closed bugs and expect someone to pick up on it.

Member

bep commented Feb 10, 2017

Please don't comment on closed bugs and expect someone to pick up on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment