Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor the globals out of site build #2701
There currently is a controlled, but careful, dance in the tests to set a set of global state before each test. While this is controlled and has no performance impact for the end result, it it not best practice, it is hard to reason about and it prevents us from using
We have done some considerably work around this area, so when we get some of the big PRs in the pipeline merged, it may be time.
From my head this means:
There are plenty of details left out in the above, but it should be complete in general.