New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RSS pages limit configurable #3035

Closed
AlekSi opened this Issue Feb 13, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@AlekSi

AlekSi commented Feb 13, 2017

Currently, there is a hard limit of 50 pages for RSS. I discovered it while investigating a report about iTunes Store removing old episodes of our podcast.

Please make this limit configurable.

@moorereason moorereason self-assigned this Feb 13, 2017

moorereason added a commit to moorereason/hugo that referenced this issue Feb 17, 2017

hugolib: Make RSS item limit configurable
Add a new rssLimit site configuration option with default of 15.  Prior
to this fix, you could create your own RSS feed to override the default
limit of 15, but we still had a hardcoded limit of 50 items set in
`hugolib.renderRSS()`.

With this option in place, the `range first 15 .Data.Pages` logic is no
longer hardcoded into the embedded RSS template.

Because the size of the slice passed to the template is now limited to
rssLimit instead of 50, this commit is a breaking change for sites
with a custom RSS template that expects more than 15 items.

Fixes #3035

@bep bep added this to the v0.19 milestone Feb 17, 2017

@bep bep closed this in #3036 Feb 17, 2017

bep added a commit that referenced this issue Feb 17, 2017

hugolib: Make RSS item limit configurable
Add a new rssLimit site configuration option with default of 15.  Prior
to this fix, you could create your own RSS feed to override the default
limit of 15, but we still had a hardcoded limit of 50 items set in
`hugolib.renderRSS()`.

With this option in place, the `range first 15 .Data.Pages` logic is no
longer hardcoded into the embedded RSS template.

Because the size of the slice passed to the template is now limited to
rssLimit instead of 50, this commit is a breaking change for sites
with a custom RSS template that expects more than 15 items.

Fixes #3035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment