New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilingual: 404 page is set to an arbitrary language #3075

Closed
mitchchn opened this Issue Feb 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@mitchchn
Contributor

mitchchn commented Feb 21, 2017

On 404.html, the value of .Language is set to the last language defined in my config file. It should instead correspond to defaultContentLanguage.

Ideally, it should be possible to create _404.md content files (and translate them) similar to how _index.md works in Hugo 0.18.

@aflashyrhetoric

This comment has been minimized.

Show comment
Hide comment
@aflashyrhetoric

aflashyrhetoric Apr 28, 2017

Any progress on this Issue? @mitchchn I'm on Hugo 0.20.2 and am still facing this issue.

aflashyrhetoric commented Apr 28, 2017

Any progress on this Issue? @mitchchn I'm on Hugo 0.20.2 and am still facing this issue.

@mitchchn

This comment has been minimized.

Show comment
Hide comment
@mitchchn

mitchchn Apr 30, 2017

Contributor

@aflashyrhetoric: I just submitted a PR to fix the bug. Full localizability for the 404 page will take more work. I wonder know how much of a demand there is for it.

Contributor

mitchchn commented Apr 30, 2017

@aflashyrhetoric: I just submitted a PR to fix the bug. Full localizability for the 404 page will take more work. I wonder know how much of a demand there is for it.

@bep bep closed this in #3413 Apr 30, 2017

bep added a commit that referenced this issue Apr 30, 2017

Render 404 in default language only
This prevents 404.html from being re-rendered for each site.

Fixes #3075
@yesh

This comment has been minimized.

Show comment
Hide comment
@yesh

yesh May 16, 2017

same issue here, full localizability needed for the 404 error.
@mitchchn we have to wait the next minor update of hugo to get your fix in an official release of hugo, right?

yesh commented May 16, 2017

same issue here, full localizability needed for the 404 error.
@mitchchn we have to wait the next minor update of hugo to get your fix in an official release of hugo, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment