New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag names with period broken #3169

Closed
joneskoo opened this Issue Mar 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@joneskoo

joneskoo commented Mar 12, 2017

I have a tag called "yx.fi" which worked fine in v0.17 but is broken in current version (v0.19). I don't use translations on my site.

In v0.17 (expected behavior), my tag "yx.fi" creates the following output:

public
├── 1
│   └── index.html
├── index.html
├── index.xml
├── sitemap.xml
└── tags
    └── yx.fi
        ├── index.html
        └── index.xml

In v0.19 (bad) the following broken structure is generated.

public
├── 1
│   └── index.html
├── index.html
├── index.xml
├── sitemap.xml
└── tags
    ├── yx
    │   └── index.fi
    └── yx.fi
        └── index.xml

I did a git bisect and found that this is the commit that first introduced the problem:

ec2d502b4f214b9505dcd57713d2236c606985e8 is the first bad commit
commit ec2d502b4f214b9505dcd57713d2236c606985e8
Author: Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
Date:   Mon Nov 7 20:24:37 2016 +0100

    node to page: Handle translations
    
    Updates #2297

:040000 040000 457d7aa9578680db9ff03ebbef763f386bbc26c8 c92bbe601bcc8d245791cd44ec890429ef8fdbf1 M	hugolib
bisect run success

So this was first broken after v0.17 but before v0.18, introduced as part of #2297 in commit ec2d502.

@joneskoo

This comment has been minimized.

Show comment
Hide comment
@joneskoo

joneskoo Mar 12, 2017

Here's the reproduction site I used, if it's needed. To reproduce, I believe just creating a tag called 'yx.fi' is sufficient. repro.zip

joneskoo commented Mar 12, 2017

Here's the reproduction site I used, if it's needed. To reproduce, I believe just creating a tag called 'yx.fi' is sufficient. repro.zip

@bep bep added the Bug label Mar 12, 2017

@bep bep added this to the v0.20 milestone Mar 12, 2017

@bep bep self-assigned this Mar 14, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 31, 2017

Member

This is fixed.

Member

bep commented Mar 31, 2017

This is fixed.

@bep bep closed this Mar 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment