New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and deprecate the disable404, disableSitemap etc. #3345

Closed
bep opened this Issue Apr 14, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@bep
Member

bep commented Apr 14, 2017

No description provided.

@bep bep added this to the v0.21 milestone Apr 14, 2017

@bep bep self-assigned this Apr 14, 2017

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
@digitalcraftsman

digitalcraftsman Apr 15, 2017

Member

Just to be sure: you're deprecating this config options because the same can be achieved disableKinds as follows:

disableKinds = ["RSS", "sitemap", "robotsTXT", "404"]
Member

digitalcraftsman commented Apr 15, 2017

Just to be sure: you're deprecating this config options because the same can be achieved disableKinds as follows:

disableKinds = ["RSS", "sitemap", "robotsTXT", "404"]
@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Apr 15, 2017

Member

Yes, those double settings are (or will be) a pain to maintain. The code is shattered with double ifs and double tests etc.

Member

bep commented Apr 15, 2017

Yes, those double settings are (or will be) a pain to maintain. The code is shattered with double ifs and double tests etc.

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
@digitalcraftsman

digitalcraftsman Apr 15, 2017

Member

Thanks for the confirmation. And yes, the new approach is much cleaner.

Member

digitalcraftsman commented Apr 15, 2017

Thanks for the confirmation. And yes, the new approach is much cleaner.

@bep bep closed this in 5794a26 May 10, 2017

@ghost ghost referenced this issue May 22, 2017

Open

spf13/hugo v0.21 released #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment