New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually built v0.20.4 declares itself as v0.21-DEV #3388

Closed
sigma opened this Issue Apr 25, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@sigma

sigma commented Apr 25, 2017

I'm not sure I understand the git history leading to tag v0.20.4, but it seems to include the commit that bumped helpers.CurrentHugoVersion to 0.21-DEV
That is also reflected in the released source package for that version.

On the other hand, the binary artifacts I tried for that release declare a version v0.20.4, which puzzles me. Am I overlooking a subtlety of goreleaser ?
If so, how exactly are we supposed to build hugo so that hugo version displays the right number ?

Thanks

@bep bep added the Bug label Apr 25, 2017

@bep bep added this to the v0.20.5 milestone Apr 25, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Apr 25, 2017

Member

Am I overlooking a subtlety of goreleaser ?

No, you are overlooking some fault in ... me. I will look into this and get out a proper version in a little bit.

I had this version-replacement logic (we have the Hugo version in a couple of places, not just Go code), and it worked for the first patch release, but not for the second ...

Member

bep commented Apr 25, 2017

Am I overlooking a subtlety of goreleaser ?

No, you are overlooking some fault in ... me. I will look into this and get out a proper version in a little bit.

I had this version-replacement logic (we have the Hugo version in a couple of places, not just Go code), and it worked for the first patch release, but not for the second ...

@bep bep closed this Apr 25, 2017

@ghost ghost referenced this issue Apr 25, 2017

Open

spf13/hugo v0.20.5 released #6

@tombennet

This comment has been minimized.

Show comment
Hide comment
@tombennet

tombennet Apr 27, 2017

Contributor

@bep This issue seems to have recurred in 0.20.6 - running hugo version returns Hugo 0.21-DEV, as does the .Hugo.Generator variable. Unless I too have overlooked something...
Thanks!

Contributor

tombennet commented Apr 27, 2017

@bep This issue seems to have recurred in 0.20.6 - running hugo version returns Hugo 0.21-DEV, as does the .Hugo.Generator variable. Unless I too have overlooked something...
Thanks!

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Apr 27, 2017

Member

@tombennet you are right, and I did not understand what happened the last time, but now I do. The tag got created by GitHub before the version numbers got updated; so while the binaries reported correct version, the tagged code was one version early. I have replaced the tag with the correct one, so now the source is also correct.

Member

bep commented Apr 27, 2017

@tombennet you are right, and I did not understand what happened the last time, but now I do. The tag got created by GitHub before the version numbers got updated; so while the binaries reported correct version, the tagged code was one version early. I have replaced the tag with the correct one, so now the source is also correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment