New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom language codes not support in multilingual setup #3564

Closed
bep opened this Issue Jun 6, 2017 · 17 comments

Comments

Projects
None yet
3 participants
@bep
Member

bep commented Jun 6, 2017

@bep bep added this to the v0.22 milestone Jun 6, 2017

@bep bep modified the milestones: v0.22, v0.23 Jun 8, 2017

@bogem bogem self-assigned this Jun 9, 2017

@bep bep modified the milestones: v0.23, v0.24, v0.25 Jun 16, 2017

@bep bep modified the milestones: v0.25, v0.26 Jul 5, 2017

@bep bep modified the milestones: v0.26, v0.27 Aug 6, 2017

@bep bep modified the milestones: v0.27, v0.28 Sep 7, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Oct 30, 2017

Member

@bogem I have added this to an upcoming "language themed" Hugo release, and it would be great if you could take some lead on getting the PR in question into a mergeable state. Let me know if you need my help.

Member

bep commented Oct 30, 2017

@bogem I have added this to an upcoming "language themed" Hugo release, and it would be great if you could take some lead on getting the PR in question into a mergeable state. Let me know if you need my help.

@bogem

This comment has been minimized.

Show comment
Hide comment
@bogem

bogem Oct 30, 2017

Contributor

Sorry, I was on vacation. Now I'm here

Contributor

bogem commented Oct 30, 2017

Sorry, I was on vacation. Now I'm here

bep added a commit to bep/hugo that referenced this issue Nov 2, 2017

bep added a commit to bep/hugo that referenced this issue Nov 2, 2017

bep added a commit to bep/hugo that referenced this issue Nov 4, 2017

i18n: Allow custom language codes
Use the new `RegisterPluralSpec` function to register all defined
languages. This allows the usage of language identifiers which are not
part of the Unicode CLDR standard.

Closes gohugoio#3564

bep added a commit to bep/hugo that referenced this issue Nov 4, 2017

@bep bep closed this in bb04010 Nov 4, 2017

bep added a commit that referenced this issue Nov 4, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Nov 5, 2017

Member

I get some related "nil pointer" now when I run this on my site with two (valid) languages. I think this one needs some more testing.

Member

bep commented Nov 5, 2017

I get some related "nil pointer" now when I run this on my site with two (valid) languages. I think this one needs some more testing.

@bep bep reopened this Nov 5, 2017

@bep bep removed the Hacktoberfest label Nov 5, 2017

@bep bep self-assigned this Nov 5, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Nov 5, 2017

Member

I had to revert this to how it behaved before. The fix for this at least broke existing sites. I got a nil pointer in the Plural func inside of go-i18n. I notice that an empty plural spec is created even for the valid languages (which has a built in plural spec) which I don't think makes sense. It doesn't work, for one.

Member

bep commented Nov 5, 2017

I had to revert this to how it behaved before. The fix for this at least broke existing sites. I got a nil pointer in the Plural func inside of go-i18n. I notice that an empty plural spec is created even for the valid languages (which has a built in plural spec) which I don't think makes sense. It doesn't work, for one.

@bep bep removed their assignment Nov 5, 2017

@kevingimbel

This comment has been minimized.

Show comment
Hide comment
@kevingimbel

kevingimbel Nov 5, 2017

Contributor

@bep Do you think we can do anything about it or is it a go-i18n problem?

Contributor

kevingimbel commented Nov 5, 2017

@bep Do you think we can do anything about it or is it a go-i18n problem?

bep added a commit to bep/go-i18n that referenced this issue Nov 5, 2017

Export GetPluralSpec
This is a follow up to this long-lived Hugo issue:

gohugoio/hugo#3564

This may be improved on in nicksnyder#82 -- but this one is needed just go get it done.

The plan for Hugo's part is:

For all the language codes in use:

1. Check if it is already registered (`GetPluralSpec`)
2. If not, register it as an alias to `GetPluralSpec("en")`

@bep bep referenced this issue Nov 5, 2017

Merged

Export GetPluralSpec #83

@bep

This comment has been minimized.

Show comment
Hide comment
@bep
Member

bep commented Nov 5, 2017

nicksnyder added a commit to nicksnyder/go-i18n that referenced this issue Nov 5, 2017

Export GetPluralSpec (#83)
This is a follow up to this long-lived Hugo issue:

gohugoio/hugo#3564

This may be improved on in #82 -- but this one is needed just go get it done.

The plan for Hugo's part is:

For all the language codes in use:

1. Check if it is already registered (`GetPluralSpec`)
2. If not, register it as an alias to `GetPluralSpec("en")`

@bep bep assigned bep and unassigned bogem Nov 6, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Nov 6, 2017

Member

I really need this in the upcoming release, so I'm going to take a stab on fixing this myself.

Member

bep commented Nov 6, 2017

I really need this in the upcoming release, so I'm going to take a stab on fixing this myself.

bep added a commit to bep/hugo that referenced this issue Nov 6, 2017

bep added a commit to bep/hugo that referenced this issue Nov 6, 2017

bep added a commit to bep/hugo that referenced this issue Nov 6, 2017

bep added a commit that referenced this issue Nov 6, 2017

@bep bep closed this in 23ba779 Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment