New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide archetype .Date that works unquoted for both TOML and YAML #3628

Closed
bep opened this Issue Jun 22, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@bep
Member

bep commented Jun 22, 2017

No description provided.

@bep bep added the Enhancement label Jun 22, 2017

@bep bep added this to the v0.24.1 milestone Jun 22, 2017

@anthonyfok

This comment has been minimized.

Show comment
Hide comment
@anthonyfok

anthonyfok Jun 22, 2017

Contributor

This seems to be a regression that happened between v0.21 and v0.22 based on my limited/preliminary testing, and seemingly applies only to TOML, as in the following error:

ERROR 2017/06/22 13:41:27 failed to parse page metadata for "post/former.md": Near line 2 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got '+' instead

did not appear in v0.21 with an unquoted date in a TOML front matter, and hugo server continues to happily serves the website showing apparently correct article dates.

Contributor

anthonyfok commented Jun 22, 2017

This seems to be a regression that happened between v0.21 and v0.22 based on my limited/preliminary testing, and seemingly applies only to TOML, as in the following error:

ERROR 2017/06/22 13:41:27 failed to parse page metadata for "post/former.md": Near line 2 (last key parsed ''): expected a top-level item to end with a newline, comment, or EOF, but got '+' instead

did not appear in v0.21 with an unquoted date in a TOML front matter, and hugo server continues to happily serves the website showing apparently correct article dates.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jun 22, 2017

Member

We switched TOML lib in 0.22.

Member

bep commented Jun 22, 2017

We switched TOML lib in 0.22.

@anthonyfok

This comment has been minimized.

Show comment
Hide comment
@anthonyfok

anthonyfok Jun 22, 2017

Contributor

We switched TOML lib in 0.22.

Thank you so much for your insight! BurntSushi/toml for front matter TOML since v0.22!
I was looking in completely wrong places.

I went ahead and submitted a PR at BurntSushi/toml#182. Hope that's the right way to do it. :-)

Contributor

anthonyfok commented Jun 22, 2017

We switched TOML lib in 0.22.

Thank you so much for your insight! BurntSushi/toml for front matter TOML since v0.22!
I was looking in completely wrong places.

I went ahead and submitted a PR at BurntSushi/toml#182. Hope that's the right way to do it. :-)

@bep bep added Bug Upstream and removed Bug labels Jun 22, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jun 23, 2017

Member

FIxed in 0e1bda3

Member

bep commented Jun 23, 2017

FIxed in 0e1bda3

@bep bep closed this Jun 23, 2017

@bep bep added Bug and removed Enhancement labels Jun 23, 2017

@anthonyfok

This comment has been minimized.

Show comment
Hide comment
@anthonyfok

anthonyfok Jun 26, 2017

Contributor

For reference:
Follow up PR at BurntSushi/toml#185 "Complete the testing for decoding datetime with UTC offset"

Contributor

anthonyfok commented Jun 26, 2017

For reference:
Follow up PR at BurntSushi/toml#185 "Complete the testing for decoding datetime with UTC offset"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment