New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Blackfriday v2 #3949

Open
bep opened this Issue Oct 8, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@bep
Copy link
Member

bep commented Oct 8, 2017

@bep bep added the Enhancement label Oct 8, 2017

@bep bep added this to the v0.31 milestone Oct 8, 2017

@vassudanagunta

This comment has been minimized.

Copy link
Contributor

vassudanagunta commented Oct 9, 2017

More flexibility for custom renderers and access to the syntax tree will be huge! I have been working on something for Hugo that could use both of these features.

@moorereason moorereason changed the title Upgrad to Blackfriday v2 Upgrade to Blackfriday v2 Oct 9, 2017

@bep

This comment has been minimized.

Copy link
Member Author

bep commented Oct 16, 2017

@chaseadamsio part of me wanted to jump on this so I just pulled in v2 to get a sense of the scope of everything. And I notice that goorgeous is using the BF renderer -- which is great news in the long run of it all (think ToC support etc.) , but that means that we should update that library as part of this task. And it would be great if we could do a dugnad on this ... some time. Where you could potentially create a v2 branch of your project or something ...

@chaseadamsio

This comment has been minimized.

Copy link
Contributor

chaseadamsio commented Oct 16, 2017

👍 I can try and do that sometime this week. chaseadamsio/goorgeous#69 v2.0.0 in the pipeline.

@chaseadamsio

This comment has been minimized.

Copy link
Contributor

chaseadamsio commented Oct 16, 2017

@bep: https://github.com/chaseadamsio/goorgeous/tree/v2.0.0

Ran tests locally and in Travis with 2.0.0, everything looks seamless, I'm testing with my hugo install locally just to double check. Do you want me to PR the version bump (along with the blackfriday bump) or do you want to do it?

@bep

This comment has been minimized.

Copy link
Member Author

bep commented Oct 17, 2017

. Do you want me to PR the version bump (along with the blackfriday bump) or do you want to do it?

I will do tit as part of a "bigger scope". Do you mean that you were able to pull in the BF v2 without any code changes?

@chaseadamsio

This comment has been minimized.

Copy link
Contributor

chaseadamsio commented Oct 17, 2017

@bep that's correct. I checked out BF v2 locally and ran tests, added it as a go dependency to goorgeous and did a sanity that the HTMLRenderer signature that goorgeous uses from BlackFriday hasn't changed and sanitied methods that goorgeous is calling to make sure the API hasn't changed. Goorgeous is compatible with BF v2. Since there's a hard dependency on it, I went ahead and cut a 2.0.0 version of goorgeous in case the API does change.

@bep bep self-assigned this Oct 21, 2017

bep added a commit to bep/hugo that referenced this issue Oct 22, 2017

@bep bep modified the milestones: v0.31, v0.32 Oct 30, 2017

@bep bep modified the milestones: v0.32, v0.33 Dec 16, 2017

@bep bep modified the milestones: v0.33, v0.34 Jan 11, 2018

@bep bep modified the milestones: v0.34, v0.35, v0.36 Jan 22, 2018

@bep bep modified the milestones: v0.36, v0.37 Feb 3, 2018

@bep bep modified the milestones: v0.37, v0.38 Feb 11, 2018

@bep bep modified the milestones: v0.38, v0.39 Feb 21, 2018

@bep bep added this to the v0.41 milestone Apr 20, 2018

@bep bep modified the milestones: v0.41, v0.42 May 4, 2018

@bep bep modified the milestones: v0.42, v0.43 Jun 5, 2018

@bep bep modified the milestones: v0.43, v0.44 Jun 30, 2018

@bep bep modified the milestones: v0.44, v0.45, v0.46 Jul 10, 2018

@bep bep modified the milestones: v0.46, v0.47 Aug 3, 2018

@bep bep modified the milestones: v0.47, v0.48 Aug 7, 2018

@bep bep modified the milestones: v0.48, v0.49 Aug 28, 2018

@bep bep modified the milestones: v0.49, v0.50 Sep 24, 2018

@bep bep modified the milestones: v0.50, v0.51 Oct 6, 2018

@bep bep modified the milestones: v0.51, v0.53 Nov 8, 2018

@bep bep modified the milestones: v0.53, v0.54 Dec 6, 2018

@bep bep modified the milestones: v0.54, v0.55 Dec 26, 2018

@bep bep modified the milestones: v0.55, v0.56 Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment