New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sitemap error: Namespace prefix xhtml on link is not defined (in multilingual site) #3978

Closed
MunifTanjim opened this Issue Oct 17, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@MunifTanjim
Contributor

MunifTanjim commented Oct 17, 2017

Hugo version: 0.30

0859d9d wraps xmlns:xhtml="http://www.w3.org/1999/xhtml" with if .IsTranslated block.

But as far as I know, .IsTranslated will always return false for the sitemap.xml template. So, xmlns:xhtml="http://www.w3.org/1999/xhtml" is never rendered. And it causes the following error:

Namespace prefix xhtml on link is not defined

I might be wrong, but I think #3933 should be reverted.

I've tested this on a multilingual site.

@MunifTanjim MunifTanjim changed the title from sitemap: Namespace prefix xhtml on link is not defined to sitemap error: Namespace prefix xhtml on link is not defined (in multilingual site) Oct 17, 2017

@bep bep added the Bug label Oct 17, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Oct 17, 2017

Member

Where do you get that validation error? Is it a "blocker"?

Member

bep commented Oct 17, 2017

Where do you get that validation error? Is it a "blocker"?

@MunifTanjim

This comment has been minimized.

Show comment
Hide comment
@MunifTanjim

MunifTanjim Oct 17, 2017

Contributor

With the mentioned error present, Google Webmasters tool reports that the sitemap.xml file can't be parsed:

Google Webmasters tool
google-webmaster-hugo-sitemap-error

Google Chrome browser
google-chrome-hugo-sitemap-error

Contributor

MunifTanjim commented Oct 17, 2017

With the mentioned error present, Google Webmasters tool reports that the sitemap.xml file can't be parsed:

Google Webmasters tool
google-webmaster-hugo-sitemap-error

Google Chrome browser
google-chrome-hugo-sitemap-error

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Oct 17, 2017

Member

OK, that's not good.

Member

bep commented Oct 17, 2017

OK, that's not good.

@bep bep added this to the v0.30.1 milestone Oct 17, 2017

@git001

This comment has been minimized.

Show comment
Hide comment
@git001

git001 Oct 17, 2017

Answer to #3978 (comment)

.. Is it a "blocker"?

Yes, this prevents me to update from 0.27.1 to 0.3x

git001 commented Oct 17, 2017

Answer to #3978 (comment)

.. Is it a "blocker"?

Yes, this prevents me to update from 0.27.1 to 0.3x

@bep bep closed this in 5109ed5 Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment