New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure shortcode does not parse the height argument #4014

Closed
kaushalmodi opened this Issue Oct 26, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@kaushalmodi
Member

kaushalmodi commented Oct 26, 2017

Looking at the source, only the width argument is parsed in the figure shortcode, not the height.


Discourse thread

@kaushalmodi

This comment has been minimized.

Show comment
Hide comment
@kaushalmodi

kaushalmodi Oct 26, 2017

Member

I can work on a PR. Though, I was wondering why the source (like the one I linked above) is stringent with newlines? With so many with .. ends on the same line, reading that code is difficult atleast in my opinion.

Would it be OK to break that figure code into multiple newlines in my PR?

Member

kaushalmodi commented Oct 26, 2017

I can work on a PR. Though, I was wondering why the source (like the one I linked above) is stringent with newlines? With so many with .. ends on the same line, reading that code is difficult atleast in my opinion.

Would it be OK to break that figure code into multiple newlines in my PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment