Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pygments #4491

Closed
bep opened this issue Mar 11, 2018 · 12 comments
Closed

Remove Pygments #4491

bep opened this issue Mar 11, 2018 · 12 comments
Labels
Milestone

Comments

@bep
Copy link
Member

@bep bep commented Mar 11, 2018

We now have Chroma as the default. I dont't see a reason to keep the old Python Pygments.

So, here is the plan:

  1. Deprecate pygmentsuseclassic: true
  2. Create aliases for the setting below below the map highlighter (or highlight?)
pygmentscodefences: true
pygmentscodefencesguesssyntax: false
pygmentsoptions: ""
pygmentsstyle: "friendly"
pygmentsuseclasses: true

We should maybe hold off with the docs update to the new values.

/cc @kaushalmodi

@bep bep added the Enhancement label Mar 11, 2018
@bep bep added this to the v0.38 milestone Mar 11, 2018
@bep bep added the Keep label Mar 11, 2018
@kaushalmodi

This comment has been minimized.

Copy link
Member

@kaushalmodi kaushalmodi commented Mar 11, 2018

That's awesome!

+1 for highlight.. highlightoptions, highlightstyle, .. sound great.

@bep

This comment has been minimized.

Copy link
Member Author

@bep bep commented Mar 12, 2018

@kaushalmodi

This comment has been minimized.

Copy link
Member

@kaushalmodi kaushalmodi commented Mar 15, 2018

On another thought.. just being devil's advocate, Chroma is probably not a 100% replacement for Pygments at least for some folks (even though, it is for me). Pygments supports many options that Chroma does not.

So if Pygments is deprecated, it will be terrible for the folks using the Pygments options unavailable in Chroma.

If it doesn't hurt (doesn't have maintenance headache), I'd suggest leaving Pygments in.


But my +1 for renaming the the pygments* options to highlight* options still stands!

@bep bep modified the milestones: v0.38, v0.39 Mar 20, 2018
@bep bep modified the milestones: v0.39, v0.40 Apr 9, 2018
@bep bep modified the milestones: v0.40, v0.41 Apr 20, 2018
@bep bep modified the milestones: v0.41, v0.42 May 4, 2018
@mckern

This comment has been minimized.

Copy link

@mckern mckern commented May 13, 2018

The Chroma highlighter still has some Ruby bugs, which Pygments does not, and it's probably not the only language. How long will Pygments continue to be available after deprecation?

@bep

This comment has been minimized.

Copy link
Member Author

@bep bep commented May 21, 2018

@mckern it is usually the deprecation version +1. But do not worry, the cost of keeping the Pygments integration is low, so I'll just keep this as a tracking issue and revisit once Chroma is fully stable. At some point I want to get rid of that extra code, but no rush.

@mckern

This comment has been minimized.

Copy link

@mckern mckern commented May 21, 2018

Great, thank you so much for the follow up!

@bep bep modified the milestones: v0.42, v0.43 Jun 5, 2018
@bep bep modified the milestones: v0.43, v0.44 Jun 30, 2018
@bep bep modified the milestones: v0.44, v0.45, v0.46 Jul 10, 2018
@bep bep modified the milestones: v0.46, v0.47, v0.48 Aug 3, 2018
@bep bep removed this from the v0.48 milestone Aug 22, 2018
@bep bep added this to the v0.53 milestone Nov 8, 2018
@bep bep modified the milestones: v0.53, v0.54 Dec 6, 2018
@bep bep modified the milestones: v0.54, v0.55 Dec 26, 2018
@bep bep modified the milestones: v0.55, v0.56 Feb 1, 2019
@bep bep modified the milestones: v0.56, v0.57 Jun 14, 2019
@bep bep modified the milestones: v0.57, v0.58 Jul 31, 2019
@bep bep modified the milestones: v0.58, v0.59 Aug 15, 2019
@bep bep modified the milestones: v0.59, v0.60 Sep 6, 2019
@bep bep modified the milestones: v0.60, v0.61 Oct 21, 2019
@bep bep modified the milestones: v0.61, v0.60 Nov 10, 2019
@bep bep changed the title Deprecate Pygments Remove Pygments Nov 11, 2019
@bep

This comment has been minimized.

Copy link
Member Author

@bep bep commented Nov 25, 2019

This is done.

@bep bep closed this Nov 25, 2019
@CIAvash

This comment has been minimized.

Copy link

@CIAvash CIAvash commented Nov 27, 2019

Chroma doesn't support Raku(formerly known as Perl 6). 😞

@moorereason

This comment has been minimized.

Copy link
Contributor

@moorereason moorereason commented Nov 27, 2019

@CIAvash, open an issue with chroma.

@CIAvash

This comment has been minimized.

Copy link

@CIAvash CIAvash commented Nov 27, 2019

@moorereason I saw this:

perl6: Requires a bunch of helpers that I do not have the time to convert.

in this file and got discouraged on opening an issue. But I will open one.

@alecthomas

This comment has been minimized.

Copy link

@alecthomas alecthomas commented Nov 27, 2019

So this is a fairly common open source problem when there are proportionally a lot of users and very few contributors.

The hard truth is that I just do not have the time or inclination to add full support for languages that are difficult to support (Perl6, YAML, etc.). So basically unless people start contributing lexers, or paying someone to, they're unlikely to get added.

Unfortunately that's the reality.

@alecthomas

This comment has been minimized.

Copy link

@alecthomas alecthomas commented Nov 27, 2019

That said I forgot an idea I had, build a converter or importer for Textmate or Sublime syntax files. These files do not contain any custom code, so assuming full support in Chroma and the syntax file, the support would be complete.

The problem is I've had some difficulty finding documentation for the format, so if anyone knows where to find docs, or is willing to write an importer, that would be welcome.

onedrawingperday added a commit to gohugoio/hugoThemes that referenced this issue Dec 4, 2019
Pygments has been removed from Hugo since gohugoio/hugo#4491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.