New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add license in GitHub settings #4623

Closed
fedir opened this Issue Apr 15, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@fedir

fedir commented Apr 15, 2018

Please add license in GitHub settings of the repository.

Currently, GitHub could not identify Your project licence, and it's not shown in interface, and not available via API also.

Ref : https://help.github.com/articles/adding-a-license-to-a-repository/

@bep

This comment has been minimized.

Member

bep commented Apr 15, 2018

There is no such setting.

We have a LICENSE.md file. Not sure why it's not recognized by GH.

@fedir

This comment has been minimized.

fedir commented Apr 15, 2018

Hi !

I just get the answer from GitHub support team. Basically, GitHub uses automatic license detector : https://github.com/benbalter/licensee

I just installed it locally and get following results for gohugoio/hugo

script/git-repo https://github.com/gohugoio/hugo
License:        
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  757dedd5fd66729149269bcc83cbbd7e2ce18af6
  License:       
  Closest licenses:
    Apache-2.0 similarity:  95.04%
    ECL-2.0 similarity:     92.81%
    EPL-2.0 similarity:     56.97%

Also it's possible to compare Hugo's version with GitHub's one, to understand the differences :

bundle exec bin/licensee detect https://github.com/gohugoio/hugo --remote --license Apache-2.0
License:        
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  757dedd5fd66729149269bcc83cbbd7e2ce18af6
  License:       
  Closest licenses:
    Apache-2.0 similarity:  95.04%
    ECL-2.0 similarity:     92.81%
    EPL-2.0 similarity:     56.97%
Comparing to Apache License 2.0:
Input Length:     10158
License length:    9024
Similarity:      95.04%
diff --git a/LICENSE b/LICENSE
index c28b8e6..7616026 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,117 +1,131 @@
[-http://www.apache.org/licenses/-]{+version 2.0, january 2004 &lt;<http://www.apache.org/licenses/ &gt;+} terms and
conditions for use, reproduction, and distribution 1. [-definitions. "license"-]{+definitions “license”+}
shall mean the terms and conditions for use, reproduction, and distribution as
defined by sections 1 through 9 of this document. [-"licensor"-]{+“licensor”+} shall mean the
copyright owner or entity authorized by the copyright owner that is granting the
license. [-"legal entity"-]{+“legal entity”+} shall mean the union of the acting entity and all other
entities that control, are controlled by, or are under common control with that
entity. for the purposes of this definition, [-"control"-]{+“control”+} means i the power, direct
or indirect, to cause the direction or management of such entity, whether by
contract or otherwise, or ii ownership of fifty percent 50% or more of the
outstanding shares, or iii beneficial ownership of such entity. [-"you"-]{+“you”+} or [-"your"-]{+“your”+}
shall mean an individual or legal entity exercising permissions granted by this
license. [-"source"-]{+“source”+} form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation source, and
configuration files. [-"object"-]{+“object”+} form shall mean any form resulting from mechanical
transformation or translation of a source form, including but not limited to
compiled object code, generated documentation, and conversions to other media
types. [-"work"-]{+“work”+} shall mean the work of authorship, whether in source or object
form, made available under the license, as indicated by a copyright notice that
is included in or attached to the work an example is provided in the appendix
below . [-"derivative works"-]{+“derivative works”+} shall mean any work, whether in source or object
form, that is based on or derived from the work and for which the editorial
revisions, annotations, elaborations, or other modifications represent, as a
whole, an original work of authorship. for the purposes of this license,
derivative works shall not include works that remain separable from, or merely
link or bind by name to the interfaces of, the work and derivative works
thereof. [-"contribution"-]{+“contribution”+} shall mean any work of authorship, including the
original version of the work and any modifications or additions to that work or
derivative works thereof, that is intentionally submitted to licensor for
inclusion in the work by the copyright owner or by an individual or legal entity
authorized to submit on behalf of the copyright owner. for the purposes of this
definition, [-"submitted"-]{+“submitted”+} means any form of electronic, verbal, or written
communication sent to the licensor or its representatives, including but not
limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the
licensor for the purpose of discussing and improving the work, but excluding
communication that is conspicuously marked or otherwise designated in writing by
the copyright owner as [-"not-]{+“not+} a [-contribution."-]
[-"contributor"-]{+contribution.” “contributor”+} shall mean licensor
and any individual or legal entity on behalf of whom a contribution has been
received by licensor and subsequently incorporated within the work. 2. grant of
copyright [-license.-]{+license+} subject to the terms and conditions of this license, each
contributor hereby grants to you a perpetual, worldwide, non-exclusive,
no-charge, royalty-free, irrevocable copyright license to reproduce, prepare
derivative works of, publicly display, publicly perform, sublicense, and
distribute the work and such derivative works in source or object form. 3. grant
of patent [-license.-]{+license+} subject to the terms and conditions of this license, each
contributor hereby grants to you a perpetual, worldwide, non-exclusive,
no-charge, royalty-free, irrevocable except as stated in this section patent
license to make, have made, use, offer to sell, sell, import, and otherwise
transfer the work, where such license applies only to those patent claims
licensable by such contributor that are necessarily infringed by their
contribution s alone or by combination of their contribution s with the work to
which such contribution s was submitted. if you institute patent litigation
against any entity including a cross-claim or counterclaim in a lawsuit alleging
that the work or a contribution incorporated within the work constitutes direct
or contributory patent infringement, then any patent licenses granted to you
under this license for that work shall terminate as of the date such litigation
is filed. 4. [-redistribution.-]{+redistribution+} you may reproduce and distribute copies of the work
or derivative works thereof in any medium, with or without modifications, and in
source or object form, provided that you meet the following conditions: a you
must give any other recipients of the work or derivative works a copy of this
license; and b you must cause any modified files to carry prominent notices
stating that you changed the files; and c you must retain, in the source form of
any derivative works that you distribute, all copyright, patent, trademark, and
attribution notices from the source form of the work, excluding those notices
that do not pertain to any part of the derivative works; and d if the work
includes a [-"notice"-]{+“notice”+} text file as part of its distribution, then any derivative
works that you distribute must include a readable copy of the attribution
notices contained within such notice file, excluding those notices that do not
pertain to any part of the derivative works, in at least one of the following
places: within a notice text file distributed as part of the derivative works;
within the source form or documentation, if provided along with the derivative
works; or, within a display generated by the derivative works, if and wherever
such third-party notices normally appear. the contents of the notice file are
for informational purposes only and do not modify the license. you may add your
own attribution notices within derivative works that you distribute, alongside
or as an addendum to the notice text from the work, provided that such
additional attribution notices cannot be construed as modifying the license. you
may add your own copyright statement to your modifications and may provide
additional or different license terms and conditions for use, reproduction, or
distribution of your modifications, or for any such derivative works as a whole,
provided your use, reproduction, and distribution of the work otherwise complies
with the conditions stated in this license. 5. submission of [-contributions.-]{+contributions+}
unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you to the licensor shall be under the terms and
conditions of this license, without any additional terms or conditions.
notwithstanding the above, nothing herein shall supersede or modify the terms of
any separate license agreement you may have executed with licensor regarding
such contributions. 6. [-trademarks.-]{+trademarks+} this license does not grant permission to use
the trade names, trademarks, service marks, or product names of the licensor,
except as required for reasonable and customary use in describing the origin of
the work and reproducing the content of the notice file. 7. disclaimer of
[-warranty.-]{+warranty+} unless required by applicable law or agreed to in writing, licensor
provides the work and each contributor provides its contributions on an [-"as is"-]{+“as is”+}
basis, without warranties or conditions of any kind, either express or implied,
including, without limitation, any warranties or conditions of title,
non-infringement, merchantability, or fitness for a particular purpose. you are
solely responsible for determining the appropriateness of using or
redistributing the work and assume any risks associated with your exercise of
permissions under this license. 8. limitation of [-liability.-]{+liability+} in no event and under
no legal theory, whether in tort including negligence , contract, or otherwise,
unless required by applicable law such as deliberate and grossly negligent acts
or agreed to in writing, shall any contributor be liable to you for damages,
including any direct, indirect, special, incidental, or consequential damages of
any character arising as a result of this license or out of the use or inability
to use the work including but not limited to damages for loss of goodwill, work
stoppage, computer failure or malfunction, or any and all other commercial
damages or losses , even if such contributor has been advised of the possibility
of such damages. 9. accepting warranty or additional [-liability.-]{+liability+} while
redistributing the work or derivative works thereof, you may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity, or other
liability obligations and/or rights consistent with this license. however, in
accepting such obligations, you may act only on your own behalf and on your sole
responsibility, not on behalf of any other contributor, and only if you agree to
indemnify, defend, and hold each contributor harmless for any liability incurred
by, or claims asserted against, such contributor by reason of your accepting any
such warranty or additional liability. {+end of terms and conditions appendix: how+}
{+to apply the apache license to your work to apply the apache license to your+}
{+work, attach the following boilerplate notice, with the fields enclosed by+}
{+brackets replaced with your own identifying information. don't include the+}
{+brackets! the text should be enclosed in the appropriate comment syntax for the+}
{+file format. we also recommend that a file or class name and description of+}
{+purpose be included on the same “printed page” as the copyright notice for+}
{+easier identification within third-party archives. copyright yyyy name of+}
{+copyright owner licensed under the apache license, version 2.0 the "license" ;+}
{+you may not use this file except in compliance with the license. you may obtain+}
{+a copy of the license at http://www.apache.org/licenses/license-2.0 unless+}
{+required by applicable law or agreed to in writing, software distributed under+}
{+the license is distributed on an "as is" basis, without warranties or conditions+}
{+of any kind, either express or implied. see the license for the specific+}
{+language governing permissions and limitations under the license.+}

All of the sections surrounded by {+ and +} are additions that that tool detected. GitHub has 98% confidence requirement, so with those changes GitHub not meeting that threshold to detect this license.

If the project removes those additions, then the license will be detected properly.

Of course, it's Your choice, which version of license You would like to use.

@bep bep closed this in e136c26 Apr 15, 2018

@fedir

This comment has been minimized.

fedir commented Apr 15, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment