Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu can't be triggered when the text is Chinese #4654

Closed
LinuxSuRen opened this issue Apr 21, 2018 · 5 comments
Closed

Menu can't be triggered when the text is Chinese #4654

LinuxSuRen opened this issue Apr 21, 2018 · 5 comments
Labels

Comments

@LinuxSuRen
Copy link

My config.toml like this:

[[languages.zh.menu.docs]]
  name = "关于 Jenkins X"
  weight = 1
  identifier = "about"
  url = "/zh/about/"

Then menu html code like this:

<li class="f5 w-100 hover-bg-light-gray hover-accent-color-light fw8">
        <a href="javascript:void(0)" class="js-toggle dib w-100 link mid-gray hover-accent-color-light pl2 pr2 pv2 " data-target=".%E5%85%B3%E4%BA%8E-jenkins-x">关于 Jenkins X</a>

          
            <ul class="%E5%85%B3%E4%BA%8E-jenkins-x desktopmenu animated fadeIn list pl0 bg-light-gray dn">
              
                <li class="f6 fw4">
                  <a href="http://localhost:1313/zh/about/" class="db link hover-bg-gray hover-white pl3 pr2 pv2 black ">
                    概览
                  </a>
                </li>
              
                <li class="f6 fw4">
                  <a href="http://localhost:1313/zh/about/features/" class="db link hover-bg-gray hover-white pl3 pr2 pv2 black ">
                    Features
                  </a>
                </li>
              
                <li class="f6 fw4">
                  <a href="http://localhost:1313/zh/about/concepts/" class="db link hover-bg-gray hover-white pl3 pr2 pv2 black ">
                    Concepts
                  </a>
                </li>
              
                <li class="f6 fw4">
                  <a href="http://localhost:1313/zh/about/license/" class="db link hover-bg-gray hover-white pl3 pr2 pv2 black ">
                    License
                  </a>
                </li>
              
            </ul>
          
        </li>

In this case, it can't triggered the menu item according the data-target, because it has been encoded.
Maybe hugo can add a custom data-target attribute for menu config.

Mac OS X 10.10.4 (14E46)
Hugo Static Site Generator v0.39-DEV-2AAB6DE darwin/amd64 BuildDate: 2018-04-13T20:49:19+0800

@bep
Copy link
Member

bep commented Apr 21, 2018

Thanks for getting in touch, but it feels like this is a question that would be better suited to the Hugo Discussion Forum. We prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug. You may also find the answers you search for in Hugo Documentation.

@bep bep closed this as completed Apr 21, 2018
@LinuxSuRen
Copy link
Author

I know that, but also think of it's a bug. I can research it again.
@bep

@anthonyfok
Copy link
Member

anthonyfok commented Apr 23, 2018

Follow-up at:

@LinuxSuRen
Copy link
Author

My problem already done, thank you everyone.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants