Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons for Simple mode Hugo shortcodes #4763

Closed
onedrawingperday opened this issue May 24, 2018 · 6 comments
Closed

Icons for Simple mode Hugo shortcodes #4763

onedrawingperday opened this issue May 24, 2018 · 6 comments
Assignees

Comments

@onedrawingperday
Copy link
Contributor

onedrawingperday commented May 24, 2018

Related PR: #4747
Related Issues: #4749 #4764

Proposal A
I designed these control icons for use in the Simple Mode Hugo shortcodes inspired by the hexagon that is used in the Hugo logo.

hugo-icons

I have made 2 variations of the play button for you to choose what you prefer.

Example display for YouTube/Vimeo with the first play button

yt-vimeo-hugo-1

Example display for YouTube/Vimeo with the second play button

yt-vimeo-hugo-2

Example display for the Speaker Deck Simple Mode Shortcode

speaker-deck-hugo

Proposal B
As an alternative the following Fork Awesome svg icons can be used in the Hugo Simple Mode shortcodes. The licence for these icons is fully Open Source and is available here

fork-awesome-icons

Example display for YouTube/Vimeo with Fork Awesome play button

yt-vimeo-fork-awesome

Example display for the Speaker Deck Simple Mode Shortcode with Fork Awesome Icons

speaker-deck-fork-awesome

CC/ @bep and anyone else

@bep
Copy link
Member

bep commented May 24, 2018

I think we should go with the traditional round play button.

@onedrawingperday
Copy link
Contributor Author

onedrawingperday commented May 24, 2018

Ok. Which round play button mine or the Fork Awesome one?

What about Speaker Deck? Is the proposed display what you have in mind for this shortcode?

@bep
Copy link
Member

bep commented May 24, 2018

Yours (assuming that you want to release it under the Apache 2 license). The Fork Awesome license looks too hard to grasp in 10 minutes.

@onedrawingperday
Copy link
Contributor Author

I will send a PR later today for the play icon and ask you to review it.

The markup is different because there is a circle now.

I will include a release note with a link to the Apache 2 licence in the PR message. Is that good enough?

@onedrawingperday
Copy link
Contributor Author

onedrawingperday commented May 31, 2018

I am closing this issue since all simple variants that need icons have been developed except for #4764

I will send a PR about the Speaker Deck simple variant one of these days and we can discuss if this particular shortcode needs icons there.

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants