New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"# more" does not work in org-mode #5381

Closed
fliar opened this Issue Oct 30, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@fliar

fliar commented Oct 30, 2018

it worked before, but currently I have to replace it with <!--more-->

@fliar fliar changed the title from "# more" did not work in org-mode to "# more" does not work in org-mode Oct 30, 2018

@bep

This comment has been minimized.

Member

bep commented Oct 30, 2018

Hmm... Thanks for the report.

@bep bep added the Bug label Oct 30, 2018

@bep bep modified the milestones: v0.51, v0.50.1 Oct 30, 2018

bep added a commit to bep/hugo that referenced this issue Oct 30, 2018

@mlake

This comment has been minimized.

mlake commented Oct 31, 2018

Also...shortcodes ahead of !--more-- aren't processed (they used to be). Possibly a separate bug

@bep

This comment has been minimized.

Member

bep commented Oct 31, 2018

Possibly a separate bug

No, it's the same.

bep added a commit to bep/hugo that referenced this issue Oct 31, 2018

bep added a commit to bep/hugo that referenced this issue Oct 31, 2018

bep added a commit to bep/hugo that referenced this issue Oct 31, 2018

bep added a commit to bep/hugo that referenced this issue Oct 31, 2018

bep added a commit to bep/hugo that referenced this issue Oct 31, 2018

@bep bep closed this in #5383 Oct 31, 2018

bep added a commit that referenced this issue Oct 31, 2018

@bep

This comment has been minimized.

Member

bep commented Oct 31, 2018

@fliar I have revised the implementation of this and added some more test cases. I'll admit that I don't use Org Mode myself and I have never seen a document with # more in it, but I assume it's just a delimiter ... Note that this also kind of worked in Hugo 0.50 but it was very picky about whitespace.

@kaushalmodi

This comment has been minimized.

Member

kaushalmodi commented Nov 1, 2018

I have never seen a document with # more in it, but I assume it's just a delimiter

# foo is just a comment in Org mode.

Goorgeous considers # more as a special Org comment to insert <--more--> in HTML. I wish it used a better syntax like #+hugo: more. But that ship has sailed, I guess.

@fliar

This comment has been minimized.

fliar commented Nov 9, 2018

@bep I've updated Hugo to 0.51 and the bug is not fixed

here's the test org file I created with hugo new command (rename it to test.org)

test.txt

file content:

---
title: "Test"
date: 2018-11-09T23:02:52+08:00
draft: true
---

this is summary

# more

this is content

Hugo outputs this:

Test

Nov 09 2018, 23:02
this is summary this is content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment