Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginators not recalculated on server lazy re-rendering #5406

Closed
bep opened this issue Nov 5, 2018 · 1 comment · Fixed by #5409
Closed

Paginators not recalculated on server lazy re-rendering #5406

bep opened this issue Nov 5, 2018 · 1 comment · Fixed by #5409
Milestone

Comments

@bep
Copy link
Member

bep commented Nov 5, 2018

ERROR 2018/11/05 15:26:58 Failed to render pages: render of "section" failed: "/Users/bep/dev/go/gohugoio/hugoDocs/themes/gohugoioTheme/layouts/showcase/list.html:12:16": execute of template failed: template: showcase/list.html:12:16: executing "main" at <.Paginate>: error calling Paginate: invoked multiple times with different arguments

Note that normally this isn't an issue, but in the showcase section on the gohugo.io site, we have a paginator that changes randomly:

{{ range (.Paginate (.Pages | shuffle ) 20).Pages  }}
@bep bep added this to the v0.51 milestone Nov 5, 2018
@bep bep added Bug and removed NeedsInvestigation labels Nov 6, 2018
@bep bep changed the title Issue with fast/lazy render and paginators Paginators not recalculated on lazy re-rendering Nov 6, 2018
@bep bep changed the title Paginators not recalculated on lazy re-rendering Paginators not recalculated on server lazy re-rendering Nov 6, 2018
bep added a commit to bep/hugo that referenced this issue Nov 6, 2018
bep added a commit to bep/hugo that referenced this issue Nov 6, 2018
@bep bep closed this as completed in #5409 Nov 6, 2018
bep added a commit that referenced this issue Nov 6, 2018
bep added a commit to bep/hugo that referenced this issue Nov 6, 2018
So it also is included when we're doing "lazy rendering" of pages visited in browser.

See gohugoio#5406
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant