New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontmatter in html comment is suddenly ignored #5478

Closed
gonapps opened this Issue Nov 28, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@gonapps

gonapps commented Nov 28, 2018

I have used v0.46 hugo and there were no problems in front matter.
But now frontmatter in a html comment like this is ignored in v0.51
And I didn't tried other versions.
Is this a bug or an intended change?

<!--
+++
title = "hello"
+++
-->

@gonapps gonapps changed the title from frontmatter in html comment is suddenly ignored to Frontmatter in html comment is suddenly ignored Nov 28, 2018

@bep

This comment has been minimized.

Member

bep commented Nov 28, 2018

I rewrote the page parser in 0.51 (for many reasons), and I may have interpreted the old "comment out" logic.

@bep bep added this to the v0.52 milestone Nov 28, 2018

@bep bep added the Bug label Nov 28, 2018

@bep bep self-assigned this Nov 28, 2018

bep added a commit to bep/hugo that referenced this issue Nov 28, 2018

parser/pageparser: Fix handling of commented out front matter
When the page parser was rewritten in 0.51, this was interpreted literally, but commented out front matter is used in the wild to "hide it from GitHub", e.g:

```
<!--
+++
title = "hello"
+++
-->
```

Fixes gohugoio#5478

@bep bep closed this in #5479 Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment